[HOLD for payment 2023-10-23] 🟡 [$500] Add stylized receipts for distance requests

[JmillsExpensify]

One thing I think we need to re-visit now that we shipped distance v1 is the receipt. For instance, this was recommended in the original design doc, though during the review process it was deemed unnecessary.

I think in hindsight that decision hasn’t turned out to be a great one. Reason being, you have to kind of deduce what the points on the map are, so what is point A and what is point B. For SBE, it was somewhat easy since the event looks like it was close to the Burbank airport? But yeah, I think a core part of mileage is knowing where someone went, whether it’s from A to B, or A to B to C.

As a result, I think we need to:

• Utilize the stylized receipt pattern that we've settled on for eReceipts
• Apply the same foundational styling for distance request
• Print the sum of a user's Start, Stop, and Finish way points, each on their own row
• All while still showing the core information about the request, such as amount, date and distance merchant.

I'm going to assign the internal label, as this is dependent on related internal initiatives and Expensify employees have the most context. We can involve external as soon as the scope and todos are clear.

cc distance project team @neil-marcellini @hayata-suenaga @arosiclair @trjExpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b483120a2e8ed4dd
• Upwork Job ID: 1700221182911156224
• Last Price Increase: 2023-09-11

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b483120a2e8ed4dd

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[hayata-suenaga]

I think the waypoints are stored in Transaction that is returned from the OpenReport and other relevant API commands?

I think edits that need to be made are in the NewDot side. Let's make this external 🚀

@Expensify/design could you double check the design?

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @mollfpr is eligible for the External assigner, not assigning anyone new.

[mollfpr]

@hayata-suenaga @JmillsExpensify I think this issue missing Help Wanted label.

[hayata-suenaga]

Thank you for pointing that out. I added the Help Wanted label 🙇

[trjExpensify]

Let's assign the Design label to this and make sure we complete getting an updated style for this in-line with the eReceipts.

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[neil-marcellini]

The PR was merged!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show eReceipts for distance requests #27204

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show eReceipts for distance requests #27204

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[JmillsExpensify]

@mollfpr I think we should have a regression test for this one, as it's a core flow and piece of compliance in the app. Do you agree and can you suggest a test?

[neil-marcellini]

100% we need a regression test, especially since it's already broken 🙈; I'm working on a fix.

[mollfpr]

Regression step for this issue:

Distance request with 2 waypoints

1. Click the green plus, request money, distance
2. Enter valid start and finish locations
3. Create the request
4. Open the money request report
5. Click on the distance request to open the transaction report
6. Click on the route image
7. Verify that the distance eReceipt is shown and looks good

Distance request with 12 waypoints

1. Click the green plus, request money, distance
2. Enter valid start and finish locations, plus 10 stops
3. Create the request
4. Open the money request report
5. Click on the distance request to open the transaction report
6. Click on the route image
7. Verify that the distance eReceipt is shown and that you can scroll down to see the entire eReceipt

---

Regression step for #28289 and #28949

1. Go offline
2. Click the green plus, request money, distance
3. Enter a valid address for start and finish waypoints
4. Verify that you can click next
5. Select a workspace
6. Verify that all information shows or is TBD
7. Click request
8. Verify that the report preview shows a pending receipt image with the amount and miles as TBD
9. Click the report preview
10. Verify that the request shows as distance, with the amount and miles as TBD
11. Click on the request
12. Verify that the request shows as distance, with the amount and miles as TBD
13. Verify that there's not Merchant input in the forms
14. Go online
15. Verify that all pending data fills

[JmillsExpensify]

Those look good to me. I'll get an issue created and add them.

[JmillsExpensify]

100% we need a regression test, especially since it's already broken 🙈; I'm working on a fix.

@neil-marcellini for the payment, are you saying that we've already had a regression and the should be reflected in payment?

[neil-marcellini]

Yes there was already a regression but we think it was due to some weird git merging behavior, and the mistake appears to have come from another PR. I commented about the regression here. No need to reduce pay for this issue.

[JmillsExpensify]

Payment summary: $500 to @mollfpr for PR review.

[JmillsExpensify]

@mollfpr Please raise a request in NewDot, going to close this one as I've created the regression test.

[JmillsExpensify]

$500 payment approved for @mollfpr based on summary above.