[HOLD for payment 2023-10-05] [$500] Web - Overlay background colour is different

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open settings on staging
2. Open settings on newdot
3. Observe the overlay color

Expected Result:

The overlay should be same as the newdot.

Actual Result:

The overlay is different from the newdot.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Monosnap.screencast.2023-09-13.19-08-29.mp4

Recording.4437.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694612443986939

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f0f92815da8d684f
• Upwork Job ID: 1702593071249002496
• Last Price Increase: 2023-09-15
• Automatic offers:
• s77rt | Reviewer | 26788621
• ishpaul777 | Contributor | 26788622
• Krishna2323 | Reporter | 26788624

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

This is from @rushatgabhane @adamgrzybowski but i dont think this is a blocker

[s-alves10]

This is a regression of this PR, but it looks by intention

[dangrous]

Yeah it seems intentional, in order to fix #26405

@shawnborton can you give this a quick look to confirm what color for the overlay is expected here? You had looked at the PR, too, but not sure if your approval included the color, or just the size issue that was being fixed. Thank you!

[ishpaul777]

I think the Background is more darker than the before, prior to navigation refactor the opacity value was 0.4 now we are using a overlayOpacity of 0.6.

Before Navigation refactore

Current

[dangrous]

removing the label, shouldn't block deploy and will sync with Shawn once he's in working hours

[shawnborton]

Chatting in Slack but yeah, I think we messed up and the overlay color is now incorrect. We should standardize on the correct color and update it everywhere. I'm thinking maybe using our colors.highLightBG color @ 72% opacity. Which would be background: rgba(7, 39, 31, 0.72); or #07271FB8 @ 72%

[shawnborton]

cc @dannymcclain

[dannymcclain]

Totally agree @shawnborton. Let's make it happen. 🚀

[ishpaul777]

Proposal

Problem

Overlay background colour is different

Root Cause

No root cause, just a color change

Changes

We need to change backgroundColor to #07271F and overlayCapacity to 0.72 in overlayStyles, we can use getBackgroundColorWithOpacityStyleutil to get the colour with opacity or use getBackgroundColorStyle and set opacity in overlayCapacity with a vairable, that we were using before navigation refactor.

[dannymcclain]

@ishpaul777 forgive me if this is a dumb comment/if I'm misunderstanding something, but the hex code #07271FB8 includes opacity, right? So if we set that as the background color AND set the opacity to 72%, won't that give us an actual opacity of 51.84%? (72% of 72% = 51.84%)

Our Highlight BG hex code is #07271F. We want that value at 72%. Just to be clear!

Just want to make sure we don't inadvertently update this to be wrong. Again, please forgive me if I am just not understanding something. 🙈
cc @shawnborton

[ishpaul777]

Hii @dannymcclain, You are right here, thanks for correcting it was dumb mistake I made. Updated the Proposal.

[dangrous]

I'm gonna add the Bug label to this so we can peruse external proposals!

Shawn and Danny - it looks like from the Slack conversation that we're going to likely want different opacities depending on the theme. Should we add that as a separate theme variable, or include it in a specific separate color variable for the overlay in the theme?

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[shawnborton]

@grgia can you provide guidance on how we should handle adding a new color variable for the modal overlay BG to both dark and light themes? Or do we just get the new dark theme value merged here and we'll deal with light mode separately?

[grgia]

We could use a helper function to set the rgba for a hex in FE. I think I've seen that pattern in app for some of these overlays. As part of this issue, we should make sure that all overlays in App reference the same variable/method

[shawnborton]

This has nothing to do with darkHighlightBackground, so no need to touch that.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[dangrous]

Assigned! Let's make sure any values that we update live inside the themes!

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @ishpaul777, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @ishpaul777 got assigned: 2023-09-21 02:41:59 Z
• when the PR got merged: 2023-09-25 03:56:59 UTC

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix overlay background color for right hand modal #27920

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @ishpaul777 requires payment offer (Contributor)
• @Krishna2323 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Fix overlay size #26385
• The offending PR has been commented on: Fix overlay size #26385 (comment)
• A discussion in #expensify-bugs has been started: I don't think this is needed here
• Determine if we should create a regression test for this bug: No

[dangrous]

Yeah this was not a bug that would have been caught by any process I don't think - we should be good! Mostly just a bit of a misunderstanding comboed with changing design

[laurenreidexpensify]

Payment Summary:

• External issue reporter @Krishna2323 - $50 - payment issued in Upwork
• Contributor that fixed the issue @ishpaul777 - $500 + 50% urgency bonus = $750, payment issued in Upwork
• Contributor+ that helped on the issue and/or PR - @s77rt - $500 + 50% urgency bonus = $750, payment issued in Upwork

[s77rt]

@laurenreidexpensify The payment here should be $250 as the PR caused a regression no bonus is applicable and the total is subject to -50%. I have refunded $500