[$500] Dev: Web - Click on back button close the RHP instead of opening Details page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to #admins >Private notes
2. Reload the page
3. Click on back icon

Expected Result:

It should navigates to Details page

Actual Result:

Close the RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.70.5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-15.at.8.02.04.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694788314587129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013c7fb2a8b63fc0bf
• Upwork Job ID: 1703126966989799424
• Last Price Increase: 2023-09-16

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013c7fb2a8b63fc0bf

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Web - Click on back button close the RHP instead of opening Details page with the case we reload the PrivateNoteListPage.

What is the root cause of that problem?

We don't define a fallback route for it here:

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Line 129 in c77814f

onBackButtonPress={() => Navigation.goBack()}

So when we reload the page, it will go back to the previous stack and it's RHN.

What changes do you think we should make in order to solve the problem?

We should define a fallback route for our onBackButtonPress funtion:

onBackButtonPress={() => Navigation.goBack(ROUTES.getReportDetailsRoute(report.reportID))}

We can also add the fallback route for other onBackButtonPress of other PrivateNotesPages (details, edit...etc..)

What alternative solutions did you explore? (Optional)

N/A

[situchan]

Dupe of #22041

[trjExpensify]

Yup, agree with that. Closing!