Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - App Fails to Redirect to Announcement Page After Split Bill #27677

Closed
1 of 6 tasks
kbecciv opened this issue Sep 18, 2023 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Sep 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to settings > workspace > create new workspace > members.
  2. Invite members to the workspace.
  3. Click on the three dots and open the announcement room.
  4. Click on the plus sign, select split bill, add the desired number, and click on split bill.
  5. The app should redirect to the announcement page, but the split bill page remains open and the app does not redirect.

Expected Result:

After splitting the bill in the workspace, the app should automatically redirect to the announcement page.

Actual Result:

The app fails to redirect to the announcement page after splitting the bill, and the split bill page remains open.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-09-18T064009.572.webm
Recording.4560.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695037437630339

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 18, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@bondydaa
Copy link
Contributor

hmm was is split bill even showing up in the + list for an #announce room?

From the looks of it after the split is created it creates a new report in the LHN since it is being split between 2 users (so a manual request) not with the workspace.

I haven't been following much with Manual Requests so I'm not 100% sure that option should be showing or not.

@bondydaa
Copy link
Contributor

opened a discussion here to see what others think https://expensify.slack.com/archives/C01GTK53T8Q/p1695057805924489

@bondydaa
Copy link
Contributor

PR to fix has been merged but not yet deployed #27793

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 Weekly KSv2 labels Sep 19, 2023
@melvin-bot melvin-bot bot changed the title Web - App Fails to Redirect to Announcement Page After Split Bill [HOLD for payment 2023-09-27] Web - App Fails to Redirect to Announcement Page After Split Bill Sep 20, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Sep 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@roryabraham roryabraham removed the DeployBlockerCash This issue or pull request should block deployment label Sep 20, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Sep 22, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-09-27] Web - App Fails to Redirect to Announcement Page After Split Bill [HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - App Fails to Redirect to Announcement Page After Split Bill Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

@bondydaa Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

@bondydaa Still overdue 6 days?! Let's take care of this!

@bondydaa
Copy link
Contributor

bondydaa commented Oct 4, 2023

i think we can close? if there is payment owed somewhere let me know

@bondydaa bondydaa closed this as completed Oct 4, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@tewodrosGirmaA
Copy link

@bondydaa I didn't get paid for bug report

@tewodrosGirmaA
Copy link

(Reporter Role) Hello, @bondydaa I was wondering if I am eligible for payment even though my issue is marked as "Awaiting Payment" and I have not yet received any payment. The issue has been closed and I would appreciate any clarification on this matter. Thank you.

@bondydaa
Copy link
Contributor

bondydaa commented Oct 5, 2023

oh doh sorry yes that seems right, lets get a bug zero person involved to handled that, sorry!

@bondydaa bondydaa reopened this Oct 5, 2023
@bondydaa bondydaa added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as off-topic.

@bondydaa
Copy link
Contributor

bondydaa commented Oct 5, 2023

@miljakljajic can you handle paying @tewodrosGirmaA for reporting the bug? thanks!

@aimane-chnaif
Copy link
Contributor

I am also eligible for fixing this bug

@miljakljajic
Copy link
Contributor

Thank you, handling!

@miljakljajic
Copy link
Contributor

sent contracts to you both

@tewodrosGirmaA
Copy link

Thank you @miljakljajic I accept the offer

@miljakljajic
Copy link
Contributor

Paid and contracts ended

@aimane-chnaif
Copy link
Contributor

@miljakljajic urgency bonus is applicable here as C+ is also external contributor

@miljakljajic
Copy link
Contributor

Bonus paid, sorry @aimane-chnaif !

@aimane-chnaif
Copy link
Contributor

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants