-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drag/drop for receipt empty state #27744
Comments
Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new. |
Job added to Upwork: https://www.upwork.com/jobs/~01e09455d07e462ca6 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif ( |
No update from me, focused on detailed design for Wave 9: Violations |
Still working through the detailed design for Wave 9. |
Still working through the detailed. |
Still focused on violations implementation first. |
Still on HOLD, but Infinite Red started on App#30663 |
App#30663 is merged so this is off hold. @cdanwards @trevor-coleman can you comment here so I can assign you? |
Commenting for assignment |
Waiting on PR |
Still not at the top of the priority list. |
Beginning work on this. |
One small design bug to fix while we're here:
|
@cdanwards please tag @Expensify/design in the PR when you create it |
Also it looks like the image is cut off - I wonder if we need to get you a better image for that? Can you share the image that you are currently using please? Thanks! |
@shawnborton sorry this got lost in my GH notifications. This one has already been merged, but here is the |
@shawnborton I'm honestly not sure. It's the right side that you're referring to, correct? There was some difficulty in having the svg display colors correctly, so that could be part of the issue. |
Exactly, see how the 1px stroke is slightly cut off? |
@shawnborton I found the issue. Going to put together a little PR with a fix for that and also the other corrections you mentioned. |
Amazing, thanks! Feel free to tag me in the PR for review. |
|
I think something is happening here, there is actually no BG color being shown at all. If there was, we wouldn't see the illustration come through. |
Much better! |
I believe all the PRs on this issue are merged right? Can we close now? |
Yes! @cdanwards please reopen if I missed anything |
If a
Collect
orControl
policy is configured with any receipt-related category violation, we’ll update the confirmation screen for manual requests and include a receipt empty state. Tapping the empty state brings up the camera (mobile) or file picker (web). For web, we’ll support drag/drop.Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: