[PAID] [$500] Members - Invite message doesn't remain when User navigate back to Invite members page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create new Workspace
2. Navigate to Members
3. Tap on Invite button
4. Invite few users
5. Tap Next
6. Edit the Invite message and put new message
7. Navigate back to Invite Members page
8. Tap Next button

Expected Result:

Invite message should remain when User come back to final Invite page

Actual Result:

Invite message doesn't remain when User navigate back to Invite members page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72-6

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6208025_az_recorder_20230920_223129.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0111f805abe8b69c9a
• Upwork Job ID: 1714431162859646976
• Last Price Increase: 2023-11-07

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users lose written invite message when they accidentally trigger back navigation

What is the root cause of that problem?

We are missing the draft saving logic on the Input Field

What changes do you think we should make in order to solve the problem?

We should pass shouldSaveDraft to the TextInput here:

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Lines 213 to 227 in 94c07ea

	<TextInput
	ref={(el) => (this.welcomeMessageInputRef = el)}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.TEXT}
	inputID="welcomeMessage"
	label={this.props.translate('workspace.inviteMessage.personalMessagePrompt')}
	accessibilityLabel={this.props.translate('workspace.inviteMessage.personalMessagePrompt')}
	autoCompleteType="off"
	autoCorrect={false}
	autoGrowHeight
	textAlignVertical="top"
	containerStyles={[styles.autoGrowHeightMultilineInput]}
	defaultValue={this.state.welcomeNote}
	value={this.state.welcomeNote}
	onChangeText={(text) => this.setState({welcomeNote: text})}
	/>

What alternative solutions did you explore? (Optional)

xx

[alexpensify]

I'm unable to test right now due to the site issues and will be traveling for work later today. If I get plane wifi, then I'll try to test either tonight or this weekend.

[alexpensify]

I'm back online and will try to test soon.

[alexpensify]

Not overdue, CM tasks are a higher priority right now. I'll test this one soon.

[alexpensify]

I confirmed this experience but I'm asking in the Open Source room to verify if the lack of stickyness is on purpose.

Here: https://expensify.slack.com/archives/C01GTK53T8Q/p1695969085525799

[melvin-bot]

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

No update in the Slack convo. I will try bumping again tomorrow.

[melvin-bot]

@alexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[alexpensify]

I bumped the thread again

[alexpensify]

Only one response so far:

Just my opinion (not based on any expected behaviour that I know of) but to me it would make sense to reset the message if the list of users invited changes and keep it sticky if nothing changes

[alexpensify]

I'm going to keep shopping around for feedback early next week.

[alexpensify]

I'm OOO today but will work on getting more feedback tomorrow

[melvin-bot]

@alexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[alexpensify]

I've sent another bump in the Slack thread.

[alexpensify]

Following some feedback that I received, I'm adding a screenshot to clarify the section of the product that this update would change:

[melvin-bot]

Upwork job price has been updated to $500

[mountiny]

Whoops wrong issue disregard!

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[alexpensify]

Reassigning another 🐛 team member, I'm going OOO until Tuesday, November 14, and will take it back if it's still open by my return date.

@muttmuure - Required action from the team:

Please keep an eye out, I haven't been able to review the deploy blocker and if it will delay the payment process for this one. Thanks!

[alexpensify]

I'm back and unassigning my buddy.

---

@allroundexperts - can you please confirm if there is regression here? I want to complete the payment process this week. Thanks!

[alexpensify]

@allroundexperts - any update here? I would like to close this one out tomorrow before I'm OOO again next week. Thanks!

[allroundexperts]

@alexpensify This did not cause a regression. Rather, it implemented the expected result. We might have decided to change the expected behaviour later on though.

[cead22]

Agreed

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[alexpensify]

Reassigning another team member, I'm going OOO until Monday, November 27, and will take it back if it's still open by my return date.

@strepanier03 - Required action from the team:

I didn't get a chance to start the payment process and input a payment summary here. This one is ready for the payment process. Thanks for helping to make sure everyone here is paid out. Thanks!

[melvin-bot]

@cead22, @alexpensify, @strepanier03, @allroundexperts, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

I was also out of the office last week so just now getting to this one.

[strepanier03]

Payment summary

• Reporter - N/A Internal report
• Contributor - @tienifr $500 paid via Upwork - Offer pending - will check later today to pay
• C+ - @allroundexperts $500 paid via Manual Requests - You're welcome to put in your request now, let me know when you do please.

[allroundexperts]

Requested @strepanier03!

[JmillsExpensify]

$500 payment approved for @allroundexperts based on summary above.

[strepanier03]

All paid up here, going to close out.