[HOLD for payment 2023-10-10] [$500] Scan - Second word of 'Choose File' button in scan request money should not be capital

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click Request money
3. Select Scan and observe that 'Choose File' button has both capital first letter for both words

Expected Result:

App should keep 'Choose File' button text as first word with capital and other words with first letter small as we do throughout the app like 'New workspace' and even in Spanish version of 'Choose File'

Actual Result:

App displays 'Choose File' button text with first letter capital for both the words in English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @ahmedGaber93
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691345773866069

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01723d17e27c5f12de
• Upwork Job ID: 1706012807304642560
• Last Price Increase: 2023-10-01
• Automatic offers:
• ahmedGaber93 | Contributor | 26971588
• ahmedGaber93 | Reporter | 26971589

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The second word of 'Choose File' button in the scan request money should not be capital, it should be "Choose file"

What is the root cause of that problem?

We used the show content button with the wrong translation for EN.

App/src/languages/en.ts

Line 481 in 4ea4a55

chooseFile: 'Choose File',

What changes do you think we should make in order to solve the problem?

We need to update:

chooseFile: 'Choose file',

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01723d17e27c5f12de

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @zanyrenney (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[ahmedGaber93]

I reporter this issue 2 months ago on slack
https://expensify.slack.com/archives/C049HHMV9SM/p1691345773866069?thread_ts=1691345773.866069&cid=C049HHMV9SM

@kbecciv Can you please add me as reporter for this issue and add my slack proposal?

[GianlucaMina]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Second word of 'Choose File' button in scan request money should not be capital

What is the root cause of that problem?

The root of the problem is located in the file src/languages/en.ts line 473 "chooseFile: 'Choose File',"

receipt: {
    upload: 'Upload receipt',
    dragReceiptBeforeEmail: 'Drag a receipt onto this page, forward a receipt to ',
    dragReceiptAfterEmail: ' or choose a file to upload below.',
    chooseReceipt: 'Choose a receipt to upload or forward a receipt to ',

    chooseFile: 'Choose File', // "Choose File" should be replaced with "Choose file"

    givePermission: 'Give permission',
    takePhoto: 'Take a photo',
    cameraAccess: 'Camera access is required to take pictures of receipts.',
    cameraErrorTitle: 'Camera Error',
    cameraErrorMessage: 'An error occurred while taking a photo, please try again',
    dropTitle: 'Let it go',
    dropMessage: 'Drop your file here',
    flash: 'flash',
    shutter: 'shutter',
    gallery: 'gallery',
},

What changes do you think we should make in order to solve the problem?

We must replace the incorrect text "Choose File" with the corresponding one "Choose file"

What alternative solutions did you explore? (Optional)

[eVoloshchak]

The fix is pretty straightforward, can confirm there is a proposal from @ahmedGaber93 posted on Slack, I think we can proceed with it

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[kbecciv]

Updated reporter @ahmedGaber93

[kbecciv]

Proposal by: @ahmedGaber93
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691345773866069

Proposal

from: @ahmedGaber93

Please re-state the problem that we are trying to solve in this issue.

dev - typo error in button "Choose File" text which sould be "Choose file"

What is the root cause of that problem?

the error on translation file here

App/src/languages/en.js

Line 358 in 1c8f935

chooseFile: 'Choose File',

What changes do you think we should make in order to solve the problem?

change the translate value to

// chooseFile: 'Choose File',
chooseFile: 'Choose file',

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[danieldoglas]

@ahmedGaber93 assigned

[ahmedGaber93]

@eVoloshchak PR is ready for review.

[melvin-bot]

🎯 ⚡️ Woah @eVoloshchak / @ahmedGaber93, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @ahmedGaber93 got assigned: 2023-10-02 01:36:47 Z
• when the PR got merged: 2023-10-02 16:59:29 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update 'chooseFile' translation in en.ts #28578

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @ahmedGaber93 requires payment offer (Contributor)
• @ahmedGaber93 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify / @zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

Payment summary:

@eVoloshchak does not require payment (Eligible for Manual Requests) owed $500 + $250 urgency bonus.
@ahmedGaber93 requires payment offer (Contributor) $500 + $250 urgency [PAID]
@ahmedGaber93 requires payment offer (Contributor) $50 [PAID]

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Add ability to Take/Upload Receipts #23046
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: there's already a comment https://github.com/Expensify/App/pull/23046/files#r1285266648
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: don't think an additional discussion is needed, we already have a checklist item for this
• Determine if we should create a regression test for this bug. The bug is trivial and has zero effect on user experience, we don't need a regression test here

[JmillsExpensify]

$750 payment approved for @eVoloshchak based on BZ summary.