Text highlighting and copy to clipboard are not working as expected

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

Selected text should be displayed if the user right clicks the message

Actual Result:

Selected text is not shown after menu open. No way user can know what is going to be copied full message or selected text.

Action Performed:

1. Navigate to a conversation
2. Highlight 2 or more lines of text in the conversation
3. Right click on the message and select copy in the menu

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.43-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Grabando.183.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

---

From @parasharrajat https://expensify.slack.com/archives/C01GTK53T8Q/p16208390261216007

When we select any text on message and press **Copy to Clipboard ** on context menu.
Selected text is not shown after menu open. No way user can know what is going to be copied full message or selected text.
You select the text and then move you cursor to different location and right click context menu will open at click location but copied text will be the selected text. In short, only copy selected text when context menu is opened over it.
You drag you cursor while clicking among messages, try to select text from multiple messages or Select the User name as well. Then Copy to Clipboard action copies everything that was selected. I think Copy to Clipboard was meant for per message only.

[MelvinBot]

Triggered auto assignment to @sonialiap (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Viacheslav80]

Proposal

we will replace the selection range after 5ms, it will have been cleared by then. Why it's cleared I don't know.
We modify executeSecondaryInteractionOnContextMenu(e) in
/src/components/PressableWithSecondaryInteraction/index.js

47:      e.preventDefault(); 
-        const selection = window.getSelection().toString();
+        const selection = window.getSelection();
+        const {anchorNode, anchorOffset, focusNode, focusOffset} = selection;
+        setTimeout(()=>selection.setBaseAndExtent(anchorNode, anchorOffset, focusNode, focusOffset), 5);
-        this.props.onSecondaryInteraction(e, selection);
+        this.props.onSecondaryInteraction(e, selection.toString());

[MelvinBot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

Bump @isagoico if you have any more context. Can we create two issues for this?

[isagoico]

Sorry for missing this before. I combined the issues since they were similar imo. Will separate them and post the other issue here 😊

[isagoico]

Created the other issue here #3134

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[michaelhaxhiu]

Oopsie, I let this one slip in favor of some other project duties. Sorry, prioritizing right now.

[michaelhaxhiu]

Ok so I think I see two separate issues/jobs, and would like a buddy check:

1. Highlighting more than 1 row of text doesn't work, whether it be top-to-bottom or bottom-to-top. It skips certain lines randomly.

2. Copy to clipboard and paste changes (i) the ordering of some text and (ii) random words/text can appear like "NEW" which weren't copied

[Jag96]

Highlighting more than 1 row of text doesn't work, whether it be top-to-bottom or bottom-to-top. It skips certain lines randomly.

This sounds like #1341 to me so I wouldn't create another job for that.

Copy to clipboard and paste changes (i) the ordering of some text and (ii) random words/text can appear like "NEW" which weren't copied

I'm not sure that is an issue here and is kind of related to #1341 so I wouldn't file anything for it.

I think the main issue here is that if you highlight part of a message and right-click, the context menu shows and then the highlighted text is unhighlighted, and the expected behavior is that the highlighted text should remain highlighted while the context menu is open.

[parasharrajat]

Yeah, @Jag96 has a point.

I think the main issue here is that if you highlight part of a message and right-click, the context menu shows and then the highlighted text is unhighlighted, and the expected behavior is that the highlighted text should remain highlighted while the context menu is open.

Also adding up to it, I think if user selects some text and open the context menu over it, only then selected text should be copied.
for eg;

My name is Rajat. E.cash is cool.

if user selects Rajat and then right click over cool then whole copy to clipboard should trigger instead of selected copy.
Make sense?

[Jag96]

if user selects Rajat and then right click over cool then whole copy to clipboard should trigger instead of selected copy.
Make sense?

Makes sense to me, it looks like this is how it is currently working on staging and production, but I agree this is an important note for regression testing for the PR that fixes this issue

[michaelhaxhiu]

Ah thanks for clarifying guys, that makes sense! 😄

[michaelhaxhiu]

I think the main issue here is that if you highlight part of a message and right-click, the context menu shows and then the highlighted text is unhighlighted

This isn't happening anymore on Web or Desktop, which is/was the core of my confusion! Here's a recording for reference of me trying many variants of copying-to-clipboard, and the context menu + highlighted text behaving properly:

Text remains highlighted when the context menu is opened via right-click.

[michaelhaxhiu]

My name is Rajat. E.cash is cool.

if user selects Rajat and then right click over cool then whole copy to clipboard should trigger instead of selected copy.
Make sense?

@parasharrajat hmm I am not having issues with this one on Web or Desktop. The only scenario for highlight + copy-to-clipboard that I think is weird right now is this one:

• I highlight some text and then right-click somewhere that is outside of the highlight text rows. See that it copies the content from where I right-clicked versus what I highlighted .
• But this is sort of an edge case to optimize for - it feels weird to right-click off your highlighted text blurb.

[michaelhaxhiu]

I'm closing this GH for the time being because the initially reported bug is no longer existent. Glad to re-open if I'm misunderstanding / or make a new GH for what @parasharrajat brought up if it's indeed a bug.