Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request money - A blank page blinks when transitioning between Request money pages #28523

Closed
6 of 7 tasks
lanitochka17 opened this issue Sep 29, 2023 · 9 comments
Closed
6 of 7 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 29, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to + > Request money
  3. Enter amount
  4. Tap Next
  5. Select a participant
  6. Tap Next

Expected Result:

The transition between one page to another page is smooth

When tapping Next, a blank page blinks before transitioning to the next page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome
  • MacOS / Desktop
  • Windows / Chrome

Version Number: 1.3.75-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219511_1696016528037.Screen_Recording_20230930_025956_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@chiragsalian
Copy link
Contributor

Does this issue occur in all platforms? I tested it on chrome on staging and on ios safari and i don't really see the same issue.
Can you retest and confirm if the issue exists and is it on all platforms?

RPReplay_Final1696023455.MP4

@lanitochka17
Copy link
Author

Reproducible:

Windows / Chrome

Recording.112.mp4

Android

0-02-01-e962dcfd45cbb1878e8a4b5138814568c1be2737dd097cf0bbb053d6011a509c_50ee41f343c2e2a1.mp4

mWeb / Chrome

0-02-01-b13f659fcde5dbad10063ba5a28a416380b4f25ab03c1185d7003b503d8bd4f9_5029396c5cf9d40f.mp4

IOS

0-02-01-b27ee46030fe507cb6b0f24eb692c0beb6fa3bc98ae7bb45e7706ddca1c16d4c_9d17445a41a2b4d0.mp4

Web / Chrome

2023-09-29.9.23.27.PM.1.mov

Desktop

2023-09-29.9.21.12.PM.1.mov

Not repro:

mWeb / Safari

0-02-01-0c7ec4faa590ae6eeace101baacf5f6eb76c7cf88cfc66e0ea5e99a6c9fcb683_686a1ba775ac5f9b.mp4

Web / Safari

2023-09-29.9.21.12.PM.2.mov

@mountiny
Copy link
Contributor

mountiny commented Oct 1, 2023

cc @tienifr @eVoloshchak could you take a lok this might be regression from this PR #27947

@tienifr
Copy link
Contributor

tienifr commented Oct 2, 2023

@mountiny @eVoloshchak I don't think this is a regression from #27947. I tried reverting the PR but the issue still persists.

Screenrecording_20231002_113652.mp4

@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2023
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Oct 2, 2023
@mountiny
Copy link
Contributor

mountiny commented Oct 2, 2023

I have tested production now and its not really much better, there is not animation or choppy one, this is not a blocker

Screen.Recording.2023-10-02.at.16.03.29.mov

I think we can close this and go back to #22388 as it seems like the transitions still not working well even after the PR

@mountiny mountiny closed this as completed Oct 2, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@mountiny mountiny added Daily KSv2 and removed Hourly KSv2 labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants