[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Android - Scan IOU - Error shows up when tapping on Capture button to take a photo

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch New Expensify app.
2. Go to + > Request money > Scan.
3. Tap on the capture button.
4. Close the error.
5. Tap Give permission and allow camera access.
6. Tap on the capture button.

Expected Result:

The image is captured

Actual Result:

An error shows up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219561_1696019114035.screen_recording_20230930_014705_new_expensify.mp4

Not repro in Production

Screen_Recording_20230930_030512_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f80a0a462cf36708
• Upwork Job ID: 1708859395779575808
• Last Price Increase: 2023-10-02

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android receipt scanning not working

What is the root cause of that problem?

The root cause of the issue is that we're supplying an extra reportId parameter here to the navigateToNextPage function. It was recently changed here and the reportID parameter was removed from the function signature.

What changes do you think we should make in order to solve the problem?

We just need to replace this with:

IOU.navigateToNextPage(iou, iouType, report, route.path);

What alternative solutions did you explore? (Optional)

None

[tgolen]

Thanks! This was probably during one of the many conflicts I had to fix.

[allroundexperts]

Thanks for the assignment. Creating PR!

[allroundexperts]

PR created #28527

[mountiny]

Gonna jump into this one to get it merged and CPed

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f80a0a462cf36708

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: use correct variables for navigateToNextPage fn #28527

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @fedirjh requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts / @fedirjh] Determine if we should create a regression test for this bug.
• [@allroundexperts / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: use correct variables for navigateToNextPage fn #28527

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @fedirjh requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts / @fedirjh] Determine if we should create a regression test for this bug.
• [@allroundexperts / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

This was a simple fix after a conflict with two PRs, the author was internal and not around in time to fix this. @allroundexperts Do you accept $250 flat fee for this fix since it was quite straightforward? We appreciate the urgency.

[mountiny]

@allroundexperts @fedirjh could you please complete the checklist here, thanks!

[fedirjh]

BugZero Checklist:

• Link to the PR: Allow Editing Distance Requests #26141

---

Regression Test Proposal

1. Launch New Expensify app on native.
2. Go to + > Request money > Scan.
3. Tap Give permission and allow camera access.
4. Tap on the capture button.
5. Verify that the image is captured and the user proceeds to the next step.

• Do we agree 👍 or 👎

[laurenreidexpensify]

@mountiny can you confirm the payment amounts for both assignees so I know what to update in the payment summary? Thanks

[mountiny]

I think flat $500 for both @allroundexperts and @fedirjh is what we should go with here based on how the issue was marked when proposals were given and accepted.

[laurenreidexpensify]

Payment Summary:

• @allroundexperts $500 - please request in newdot
• @fedirjh $500 - please apply to job in Upwork Payment issued in Upwork

[allroundexperts]

Requested. Thanks everyone!

[laurenreidexpensify]

@fedirjh I just sent over the offer now 👍

[fedirjh]

Accepted. Thank you!

[JmillsExpensify]

$500 payment approved for @allroundexperts based on summary above.