[PAID] [$500] LHN - Incorrect backup avatar while waiting for avatar to load

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app from a fresh sign in
2. Observe your own avatar in the top right of the LHN area

Expected Result:

I would expect this avatar to either use our fallback avatar image, or just be a solid icon fill circle like the rest of the loading avatars on the page

Actual Result:

The app displayed one of our default avatars while waiting for the correct avatar to load

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.76-0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-10-02.1.28.20.PM.1.mov

Expensify/Expensify Issue URL:

Issue reported by: @shawnborton

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696240585729759

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb65a5e1b63a2756
• Upwork Job ID: 1718973678534291456
• Last Price Increase: 2023-10-30
• Automatic offers:
• dukenv0307 | Contributor | 27439507

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect backup avatar while waiting for avatar to load

What is the root cause of that problem?

We pass the fallbackIcon as the default avatar of the user here to display if the data is loading

App/src/pages/home/sidebar/PressableAvatarWithIndicator.js

Line 55 in 05aa0c3

fallbackIcon={currentUserPersonalDetails.fallbackIcon}

What changes do you think we should make in order to solve the problem?

In PressableAvatarWithIndicator we can subscribe isLoading from Onyx with key ONYXKEYS.IS_LOADING_APP. And pass this to AvatarWithIndicator

App/src/pages/home/sidebar/PressableAvatarWithIndicator.js

Line 65 in c81a509

export default withCurrentUserPersonalDetails(PressableAvatarWithIndicator);

And in AvatarWithIndicator we will only display the View with background color themColors.skeletonLHNIn

<View style={[styles.sidebarAvatar, props.isLoading && {backgroundColor: themeColors.skeletonLHNIn}]}>
    {!props.isLoading && (
        <>
            <Avatar
                source={UserUtils.getSmallSizeAvatar(props.source)}
                fallbackIcon={props.fallbackIcon}
            />
            <Indicator />
        </>
    )}
</View>

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01702f576387e8afe4

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[strepanier03]

Able to repro:

[strepanier03]

All good to move forward. This was reported by one of our designers so they'd be the experts in expected behavior.

[ArekChr]

@strepanier03 Having a preview(thumbnail) image in base64 from the backend would be awesome as a fallback image.

[melvin-bot]

@strepanier03, @ArekChr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

@shawnborton is that possible?

Having a preview(thumbnail) image in base64 from the backend would be awesome as a fallback image.

I'm a little out of my depth. I can raise instead in Slack if you'd like.

[shawnborton]

I'm not entirely sure either, I would check with the engineering assignee (when we have one).

But I kind of think the right solution here is just to use the same style as the skeleton loader, and only use a fallback avatar if we can't download/access the right avatar.

[strepanier03]

Thank you @shawnborton - @ArekChr for visibility on their comment.

[ArekChr]

right solution here is just to use the same style as the skeleton loader, and only use a fallback avatar if we can't download/access the right avatar.

@dukenv0307 could you update your proposal?

[strepanier03]

@dukenv0307 friendly bump.

[melvin-bot]

@strepanier03 @ArekChr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@strepanier03, @ArekChr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@ArekChr The PR is ready for review.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Display skeleton avtar while loading #30625

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - Internal report
• Contributor that fixed the issue - @dukenv0307 - $500 via Upwork
• Contributor+ that helped on the issue and/or PR - N/A Callstack

For reference, here are some details about the assignees on this issue:

• @ArekChr does not require payment (Contractor)
• @dukenv0307 requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ArekChr] The PR that introduced the bug has been identified. Link to the PR: No bug identified.
• [@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
• [@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
• [@ArekChr] Determine if we should create a regression test for this bug: Yes
• [@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again: Done
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/339563

[ArekChr]

• Link to the PR: No bug identified.
• Link to comment: n/a
• Link to discussion: n/a
• Determine if we should create a regression test for this bug: We can create a simple test.

Regression Test Proposal

1. Open the app from a fresh sign-in
2. Verify your avatar in the top right of the LHN area; it should show the skeleton loader as a fallback image.

Do we agree 👍 or 👎

[melvin-bot]

@youssef-lr, @strepanier03, @ArekChr, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[strepanier03]

Thanks all! I was OoO last week for the holiday but am working on this now, sorry for the delay!

[strepanier03]

This has been paid, regression test is proposed, and we're ready to close.

Thank you all!