Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Chat - New message sent is not showing immediatelly #28649

Closed
6 tasks done
kbecciv opened this issue Oct 2, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 2, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Type a message
  2. Press enter to send it

Expected Result:

The message should basically immediately show in the messages list

Actual Result:

There is noticeable delay before the new message shows in chat list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.76.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-02.at.19.48.06.mp4

Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696275413656409

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f9c236f03f59da21
  • Upwork Job ID: 1708935805899952128
  • Last Price Increase: 2023-10-02
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 2, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Oct 2, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Oct 2, 2023
@melvin-bot melvin-bot bot changed the title Chat - New message sent is not showing immediatelly [$500] Chat - New message sent is not showing immediatelly Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f9c236f03f59da21

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

@ZhenjaHorbach
Copy link
Contributor

Locally on the last main, it works much better than on staging

@mountiny mountiny added the Reviewing Has a PR in review label Oct 3, 2023
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 3, 2023
@mountiny mountiny assigned mountiny and unassigned jasperhuangg Oct 3, 2023
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 3, 2023
@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2023

Also fixed in staging

@mountiny mountiny closed this as completed Oct 3, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Oct 3, 2023
@melvin-bot melvin-bot bot changed the title [$500] Chat - New message sent is not showing immediatelly [HOLD for payment 2023-10-10] [$500] Chat - New message sent is not showing immediatelly Oct 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @burczu does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 5, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-10] [$500] Chat - New message sent is not showing immediatelly [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Chat - New message sent is not showing immediatelly Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @burczu does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@kbecciv
Copy link
Author

kbecciv commented Nov 8, 2023

Issue is not reproducible on build v1.3.96-10

Recording.5243.mp4

@situchan
Copy link
Contributor

situchan commented Nov 8, 2023

@kbecciv yes, it's expected not reproducible on staging. Did you also not reproduce on this build?

@kbecciv
Copy link
Author

kbecciv commented Nov 8, 2023

Checking on special build

@kbecciv
Copy link
Author

kbecciv commented Nov 8, 2023

Not reproduced on special build

Recording.5245.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants