[HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] iOS - Chat - Suggestion list does not open when entering @ in personal or group chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open iOS App
2. Login with any account
3. Open any personal or group chat
4. Type @

Expected Result:

Suggestion list opens immediately

Actual Result:

Nothing happens
Suggestion list opens if user delete @ and type it again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.76-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6222499_1696281173759.iOS-Suggestion-list-not-open.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

This is a regression of this PR
This issue is reproducible only in staging. It's a deploy blocker, I think

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dylanexpensify]

@amyevans can we confirm this is a deploy blocker?

[amyevans]

Well we deployed about 8 hours ago, so now it is reproducible in production 😅. So no longer a deploy blocker, but still a regression that should be handled by the original participants from #28583. @lakchote @cubuspl42 @paultsimura could you take a look here please? Thanks!

[cubuspl42]

This is bad.

@lanitochka17 Does this affect only iOS Native?

I created a PR reverting the original change: #28794. I will create a thread on Slack.

[Julesssss]

We're going to revert the changes here.

[cubuspl42]

Confirmed reproducible on iOS Native:

mentions-not-showing-ios.mp4

Confirmed not reproducible on Android Native:

mentions-not-showing-android-compressed.mp4

[paultsimura]

I'm sorry guys, it's totally my bad.
I'm currently working on finding the root cause of why iOS native has an order of selection & value changes different from all other platforms.

[Julesssss]

Hey @cubuspl42 can you please fill the author checklist for the revert PR so I can review/merge/cp it?

[cubuspl42]

@paultsimura

I'm sorry guys, it's totally my bad.

It also passed through my review, the internal engineer approval, main, and QA tests on staging 🙂 We all sign under each change in a way.

[cubuspl42]

Not only is this inconsistent between platforms, but also between type of a report. We tested on iOS Native, after all...

[amyevans]

Yeah don't beat yourself up about it! The important thing is you've been active helping to fix it when a problem is uncovered 😄

[cubuspl42]

@paultsimura Please get familiar with this discussion on Slack

[shubham1206agra]

BTW there is a slack discussion going on right now
https://expensify.slack.com/archives/C01GTK53T8Q/p1696421170146759

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Handle suggestions only on selection change" #28794

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@amyevans / @Julesssss / @lakchote] The PR that introduced the bug has been identified. Link to the PR:
• [@amyevans / @Julesssss / @lakchote] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@amyevans / @Julesssss / @lakchote] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@amyevans / @Julesssss / @lakchote] Determine if we should create a regression test for this bug.
• [@amyevans / @Julesssss / @lakchote] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Handle suggestions only on selection change" #28794

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@amyevans / @Julesssss / @lakchote] The PR that introduced the bug has been identified. Link to the PR: fix: Chat - App displays mention suggestion for sometime when we remove spaces before #28583
• [@amyevans / @Julesssss / @lakchote] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [HOLD for payment 2023-11-01] [HOLD for payment 2023-10-13] [$500] Chat - App displays mention suggestion for sometime when we remove space from before @ #28170 (comment)
• [@amyevans / @Julesssss / @lakchote] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@amyevans / @Julesssss / @lakchote] Determine if we should create a regression test for this bug. Not needed, this was caught by existing regression tests
• [@amyevans / @Julesssss / @lakchote] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[dylanexpensify]

@cubuspl42 mind giving an update here?

[paultsimura]

@dylanexpensify We are waiting for @situchan's response here in slack:

https://expensify.slack.com/archives/C01GTK53T8Q/p1696421170146759

[amyevans]

I completed the checklist above - I think we can close this out since the revert is complete and no payments are due. A new plan of action for addressing the original bug can continue on Slack / in #28170.

If anyone disagrees though or if I missed something feel free to reopen!