[$500] Task - Canceled task disappears from the conversation

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any Gmail account
3. On LHN, click on the FAB button
4. Select Assign Task
5. Enter a title or description
6. Assign the task to yourself and Share Somewhere with another user you have access to
7. Click on the 3 dot menu and cancel the task

Expected Result:

The task is unmarked in the 1:1 chat where the task was shared

Actual Result:

Canceled task disappears from the conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop
• Windows / Chrome

Version Number: 1.3.76-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6222520_1696282489506.Canceled_task.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017d268a31fa534112
• Upwork Job ID: 1708977327264219136
• Last Price Increase: 2023-10-02

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017d268a31fa534112

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[nebiyuelias1]

How to reproduce this locally?

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Canceled task disappears from the conversation

What is the root cause of that problem?

We're excluding deleted action from the list of report actions here.

The cancelled task satisfies that condition so it also disappears. This is incorrect since we still want to show cancelled task because we still keep the thread for it in the LHN, so it'll be confusing to the user when they go back from the thread to the parent report and do not see any task-related information.

What changes do you think we should make in order to solve the problem?

Update this condition to allow cancelled tasks to be visible

Like below

const isDeleted = isDeletedAction(reportAction) && !ReportUtils.isCanceledTaskReport(allReports[reportAction.reportID], reportAction);

We might need to modify the optimistic data when cancelling the task for it to show accordingly in LHN as well.

What alternative solutions did you explore? (Optional)

NA

[rojiphil]

Isn’t this an expected behavior for the [Deleted task] to disappear from the conversation? That way, it would be consistent with how threads behave.

[pasala-krishna]

Proposal

issue:
Canceled task disappears from the conversation
The issue is the way cancel task task action is handled, we can change values here to make task not show deleted in the chat.

[melvin-bot]

📣 @pasala-krishna! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[pasala-krishna]

Contributor details
Expensify account email: pasala.krishna14@gmail.com
upwork profile link: https://www.upwork.com/freelancers/~01242a758658bf605d

[nebiyuelias1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Canceled task disappears from the conversation

What is the root cause of that problem?

We're excluding deleted action from the list of report actions here.

The cancelled task satisfies that condition so it also disappears. This is incorrect since we still want to show cancelled task because we still keep the thread for it in the LHN, so it'll be confusing to the user when they go back from the thread to the parent report and do not see any task-related information.

What changes do you think we should make in order to solve the problem?

Update this condition to allow cancelled tasks to be visible

Like below

const isDeleted = isDeletedAction(reportAction) && !ReportUtils.isCanceledTaskReport(allReports[reportAction.reportID], reportAction);

We might need to modify the optimistic data when cancelling the task for it to show accordingly in LHN as well.

What alternative solutions did you explore? (Optional)

NA

I wonder how you're able to test this locally? Because I wasn't able to reproduce it.

[mountiny]

@dukenv0307 Thanks for the proposal, reminding that if the issue is a deploy blocker, lets always link the offending PR.

Looking at this again though, I am not sure if this is intended or no, probably ont but does not feel like a blocker. @thienlnam from this PR #28128 might have better idea what the expected behaviour is here

[thienlnam]

Yeah this is intended in some situations, we've also been discussing this in this issue, so I'm going to close this to consolidate the discussion there