[HOLD for payment 2023-10-18] [Wave 6: Drafts] Add the autoreporting and submitted state as const to the App

[mountiny]

Part of https://github.com/Expensify/Expensify/issues/308213

Coming from the doc here, we have couple of constants which will need to be added to the App to support the drafts and its functionality.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2c7ac503d38cdb4
• Upwork Job ID: 1709977346141700096
• Last Price Increase: 2023-10-05

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue.

[rezkiy37]

@mountiny, I assume that we need to extend:

1. Policy.ts with AUTO_REPORTING_FREQUENCIES. So, how the backend call this key in a policy object?
2. OriginalMessage.ts with a new type -OriginalMessageSubmitted. Am I right? What properties does OriginalMessageSubmitted have?

Either it is a part of - #28758?

[mountiny]

Those sounds correct yeah, catching up with other things now, will tyr to get back to this asap

[melvin-bot]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2c7ac503d38cdb4

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[rezkiy37]

Also, looks like @waterim is adding the submitted state within his PR - #28947.

[mountiny]

actionName of the report action is SUBMITTED needs to be added to report.action.type here

App/src/CONST.ts

Lines 476 to 493 in cbb069c

	ACTIONS: {
	LIMIT: 50,
	TYPE: {
	APPROVED: 'APPROVED',
	ADDCOMMENT: 'ADDCOMMENT',
	CLOSED: 'CLOSED',
	CREATED: 'CREATED',
	TASKEDITED: 'TASKEDITED',
	TASKCANCELLED: 'TASKCANCELLED',
	IOU: 'IOU',
	MODIFIEDEXPENSE: 'MODIFIEDEXPENSE',
	REIMBURSEMENTQUEUED: 'REIMBURSEMENTQUEUED',
	RENAMED: 'RENAMED',
	CHRONOSOOOLIST: 'CHRONOSOOOLIST',
	TASKCOMPLETED: 'TASKCOMPLETED',
	TASKREOPENED: 'TASKREOPENED',
	REPORTPREVIEW: 'REPORTPREVIEW',
	POLICYCHANGELOG: {

As far as the originalMessage type goes, I would keep it as unknown for now. I think there can be lots of different shapes depending on the particular policy set up

[mountiny]

For the AUTO_REPORTING_FREQUENCIES, not sure if I understand your question.

We will have to add these two keys to the Policy type:

   'autoReporting' => $policyData['autoReporting'] ?? false,
   'autoReportingFrequency' => $policyData['autoReportingFrequency'] ?? 

And possibly create a new autoReportingFrequency enum using the options you see in the doc

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Add the "auto reporting" and "submitted" state as const to the App #28906

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment
• @rezkiy37 does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[mollfpr]

I'm not due any compensation here, so I'll un-assigning myself ✋

[mountiny]

Can be closed