Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-30] [Wave 6: Drafts] Show the Next step in the MoneyReportHeader #28767

Closed
mountiny opened this issue Oct 3, 2023 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2023

Part of https://github.com/Expensify/Expensify/issues/308213

Coming from here in the doc, we are going to show the next steps for the report in the moneyReportHeader component.

@mountiny mountiny added the Weekly KSv2 label Oct 3, 2023
@puneetlath puneetlath changed the title Wave6 - Drafts - Show the Next step in the MoneyReportHeader [Wave 6: Drafts] Show the Next step in the MoneyReportHeader Oct 4, 2023
@BeeMargarida
Copy link
Contributor

Hi, I’m Ana from Callstack, is this issue ready to be worked on? I would like to help

@mountiny
Copy link
Contributor Author

mountiny commented Oct 6, 2023

@BeeMargarida For context, the backend change was merged so there should be the next steps collection coming in OpenReport response for Expenses from monday #28762

@BeeMargarida
Copy link
Contributor

@BeeMargarida For context, the backend change was merged so there should be the next steps collection coming in OpenReport response for Expenses from monday #28762

Hey @mountiny, I was trying to use this, but I might be missing something. Open/draft reports don't appear in newdot yet, right? Is these next steps only returned for reports with that state, or for ones already in processing?
The next steps are not being returned in OpenReport, I'm using a newly created money request in newdot.

@mountiny
Copy link
Contributor Author

mountiny commented Oct 9, 2023

Next steps are returned for any expense report and they will start after web deploy today which might be in couple hours

@BeeMargarida
Copy link
Contributor

Update: almost ready, just having some struggles with the line wrap of the HTML renderer in native devices

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 12, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 23, 2023
@melvin-bot melvin-bot bot changed the title [Wave 6: Drafts] Show the Next step in the MoneyReportHeader [HOLD for payment 2023-10-30] [Wave 6: Drafts] Show the Next step in the MoneyReportHeader Oct 23, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 29, 2023
Copy link

melvin-bot bot commented Nov 1, 2023

@BeeMargarida, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor Author

mountiny commented Nov 2, 2023

The C+ was from agency so we can actually close this too

@mountiny mountiny closed this as completed Nov 2, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
No open projects
Development

No branches or pull requests

2 participants