Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-24] Rename Send message to Start chat everyone in app #29040

Closed
JmillsExpensify opened this issue Oct 6, 2023 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@JmillsExpensify
Copy link

JmillsExpensify commented Oct 6, 2023

Per this internal conversation, we're going to add Send money back into the product shortly. At that point we'll have the following in the global creation flow.

  • Send message
  • Request money
  • Send money
  • Assign task
  • Save the world

That's not terrible but it's more repetition than I'd like. Accordingly, let's update Send message to Start chat instead (and not just for global create, but also the first page in the Send chat route.

Keeping this internal and will assign to @techievivek since he's already started on a PR.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013e28f484f82e9774
  • Upwork Job ID: 1710402617843875840
  • Last Price Increase: 2023-10-06
@JmillsExpensify JmillsExpensify added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Oct 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013e28f484f82e9774

@melvin-bot melvin-bot bot removed the Daily KSv2 label Oct 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

@techievivek techievivek added the Reviewing Has a PR in review label Oct 9, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 9, 2023
@JmillsExpensify
Copy link
Author

Hmm, looks like the automation failed for this one, right?

@JmillsExpensify
Copy link
Author

Payment summary: $500 to @aimane-chnaif for PR testing and review.

@JmillsExpensify
Copy link
Author

Hmm, looks like the automation failed for this one, right?

Edit: I misspoke, this hasn't reached production yet.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 17, 2023
@melvin-bot melvin-bot bot changed the title Rename Send message to Start chat everyone in app [HOLD for payment 2023-10-24] Rename Send message to Start chat everyone in app Oct 17, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@JmillsExpensify
Copy link
Author

Payment summary above still applies, though @aimane-chnaif mind commenting on the regression test? I think we should be fine updating QA that the name has changed, though curious for your thoughts.

@JmillsExpensify
Copy link
Author

P.S. Offer sent via Upwork.

@aimane-chnaif
Copy link
Contributor

I think we should be fine updating QA that the name has changed

Agree. I believe there should be test case somewhere to verify that "Send message" is in FAB menu.
We can find it in Testrail and update accordingly.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 24, 2023
@JmillsExpensify
Copy link
Author

Awesome, all paid out. I've also updated QA on the name change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

3 participants