[$500] Dev: Settings Background for profile details Header is changed unintentionally while refactoring LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Pull latest changes from main
2. Open App, navigate to settings.

Expected Result:

Settings Background for profile details Header is not same as production and staging.

Actual Result:

Settings Background for profile details Header is same as production and staging.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.79.3
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696666339849009

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190dc27ba467ee399
• Upwork Job ID: 1711358815262965760
• Last Price Increase: 2023-10-09

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190dc27ba467ee399

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[kbecciv]

Proposal by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696666339849009

Proposal

Problem

Settings Background for profile details Header is changed unintentionally while refactoring LHN

Root Cause

We were referencing sidebar color for the background color which was darkHighlightBackground but recently this hs been changed while refactoring New LHN layout.

Changes

We should use highlightBG instead of sidebar color to avoid this issue in future, we should fix this for all other places where ever we reference sidebar color directly

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Setting header background color is different

What is the root cause of that problem?

We have incorect background color in styles for the setting header that matches with the background color of a settings

What changes do you think we should make in order to solve the problem?

We can update SCREENS.SETTINGS.ROOT in this style
Since this constant is used only in one place
There should be no new regressions

App/src/styles/themes/default.js

Line 96 in 7c7fa65

[SCREENS.SETTINGS.ROOT]: darkTheme.sidebar,

Like

[SCREENS.SETTINGS.ROOT]: darkTheme.highlightBG,

What alternative solutions did you explore? (Optional)

Or we can background color in header component

[hayata-suenaga]

This issue is consolidated here 🙇

Thank you everyone for proposals and I really appreciate the time you took to write these. I'm looking forward to working with you in the next issue 🚀

[ishpaul777]

hii @hayata-suenaga, Can you tag someone who can clarify the consolidated reports are eligible for report or not?