[HOLD for payment 2023-10-18] [HOLD for payment 2023-10-16] Chat - Loading appears instead of archived message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. From userA, create a workspace if not created
2. Go to settings >workspace > members
3. Add userB
4. From userB, go to workspace chat
5. From userA, remove userB
6. Verify the footer

Expected Result:

It should show archived message

Actual Result:

Loading appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.79.3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20231009_120127_New.Expensify.Dev.mp4

Screen_Recording_20231009_120607_Chrome.mp4

RPReplay_Final1696833166.MP4

Simulator.Screen.Recording.-.iPhone.13.-.2023-10-09.at.12.21.50.mp4

Screen.Recording.2023-10-09.at.12.19.37.PM.mov

Screen.Recording.2023-10-09.at.12.27.11.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696836035678109

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Looks like a regression from #27420

[amyevans]

I verified that the regression is coming from #27420 by reverting the PR locally. I think @tienifr, @robertjchen, and @jjcoffee are all offline for the evening, and the regression is worse than the original bug the PR was addressing, so I'm going to just open a revert PR.

[amyevans]

Verified the fix in staging:

So I'm going to remove the deploy blocker label, but keep this open for bug reporter payout processing.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[amyevans]

Hiii @adelekennedy, can you help issue payment to @gadhiyamanan for the bug report ($50). Thanks!

[adelekennedy]

sent offer to you @gadhiyamanan

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "fix: 26657 Another error message for a short time when opening archived chat from search bar" #29106

If no regressions arise, payment will be issued on 2023-10-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@amyevans] The PR that introduced the bug has been identified. Link to the PR:
• [@amyevans] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@amyevans] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@amyevans] Determine if we should create a regression test for this bug.
• [@amyevans] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[gadhiyamanan]

@adelekennedy offer accepted, thanks!

[tienifr]

@amyevans I don't think it's my regression. After investigating the RCA, I found out that BE server didn't return the CLOSE message (that contain the close reason) that why the skeleton is shown.

After revert my PR, we still can see the following bug (the default reason is shown, after refreshing page the correct reason will be shown)

Screen.Recording.2023-10-10.at.11.51.36.mp4

[jjcoffee]

Hmm yeah I agree that there's an existing issue here where the wrong error message appears for user B, so not exactly sure if this counts as a regression from #27420 - it's more like it masks the issue. @amyevans Any thoughts on expected behaviour here if the BE isn't returning the correct reason?

[adelekennedy]

reporting bonus paid

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "fix: 26657 Another error message for a short time when opening archived chat from search bar" #29106

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@amyevans] The PR that introduced the bug has been identified. Link to the PR: fix: 26657 Another error message for a short time when opening archived chat from search bar #27420
• [@amyevans] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: 26657 Another error message for a short time when opening archived chat from search bar #27420 (comment)
• [@amyevans] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@amyevans] Determine if we should create a regression test for this bug. Not necessary
• [@amyevans] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[amyevans]

@tienifr @jjcoffee okay I think that's fair enough, #26657 probably shouldn't incur a regression penalty since there's a reasonable expectation the CLOSED report action would be present. (Although at the same time I do think ideally this flow would have been tested prior to PR release.)

As to expected behavior, my recommendation would be to patch the backend before re-releasing the frontend PR, but I'll let y'all decide that either way in #26657!