Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment issue for E/App PR#29120 #29127

Closed
melvin-bot bot opened this issue Oct 9, 2023 · 17 comments
Closed

Payment issue for E/App PR#29120 #29127

melvin-bot bot opened this issue Oct 9, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Oct 9, 2023

Issue created to compensate the Contributor+ member for their work on #29120
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @aimane-chnaif.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013ea7643da59df4ac
  • Upwork Job ID: 1711486615671975936
  • Last Price Increase: 2023-10-09
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Oct 9, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Oct 9, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 9, 2023

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013ea7643da59df4ac

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 9, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 9, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 9, 2023

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

@abekkala
Copy link
Contributor

not deployed to production yet

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2023
@abekkala
Copy link
Contributor

not deployed to production yet

@melvin-bot melvin-bot bot added Overdue Daily KSv2 and removed Overdue Daily KSv2 labels Oct 13, 2023
@abekkala
Copy link
Contributor

not deployed to production yet

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2023
@abekkala
Copy link
Contributor

not deployed to prod yet

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 23, 2023

@abekkala @aimane-chnaif this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 23, 2023

@abekkala, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@abekkala
Copy link
Contributor

@marcochavezf Am I correct in seeing that this has not been deployed to production yet and payment should still be on Hold?

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@marcochavezf
Copy link
Contributor

Oh interesting, yes it's weird that there's no melvin message about being deployed to production, but the change exists in main. @aimane-chnaif could you verify if the issue is no longer happening in production?

@aimane-chnaif
Copy link
Contributor

No longer happening

@abekkala
Copy link
Contributor

@aimane-chnaif I've sent your Upwork payment offer!
https://www.upwork.com/nx/wm/offer/27358450

@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
@abekkala
Copy link
Contributor

@aimane-chnaif can you accept the offer from the link above so I can process payment?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 27, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 30, 2023

@abekkala @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@abekkala
Copy link
Contributor

Payment sent and contract ended - Thank you! 🎉

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

3 participants