Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-16] [Wave 6: Workspace Chats] Make optimistic requests/IOUs/expense reports “hidden” #29593

Closed
puneetlath opened this issue Oct 13, 2023 · 8 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@puneetlath
Copy link
Contributor

We want to make expense reports, IOU reports, and individual requests to use the same “hidden” setting that we use for threads so that they will be hidden from the LHN by default. Let's update the creation flows so that when these are optimistically created they have the "hidden" notification preference. This is described in the workspace chats design doc here.

Here for expense reports
Here for IOU reports
Here for individual requests

@puneetlath puneetlath added Daily KSv2 NewFeature Something to build that is a new item. labels Oct 13, 2023
@puneetlath puneetlath self-assigned this Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 13, 2023
@puneetlath puneetlath changed the title [HOLD E/E #326093] [Wave 6: Workspace Chats] Make requests/IOUs/expense reports “hidden” by default [HOLD E/E #326093] [Wave 6: Workspace Chats] Make optimistic requests/IOUs/expense reports “hidden” Oct 13, 2023
@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue.

@puneetlath puneetlath changed the title [HOLD E/E #326093] [Wave 6: Workspace Chats] Make optimistic requests/IOUs/expense reports “hidden” [Wave 6: Workspace Chats] Make optimistic requests/IOUs/expense reports “hidden” Oct 16, 2023
@puneetlath
Copy link
Contributor Author

puneetlath commented Oct 16, 2023

I'm going to go ahead and remove the HOLD. I think it's fine for us to go ahead and implement this independent from the back-end changes.

@mountiny is working on the back-end portion and until that is done, when the back-end responds it will overwrite the notification preference, so you'll need to test in offline mode @rezkiy37.

@rezkiy37
Copy link
Contributor

I have to inform that starting tomorrow I have a short vocation until next Monday (6.11.2023). Feel free to left any comments, I will address them. See you soon 😉

@puneetlath
Copy link
Contributor Author

This was merged.

@rezkiy37
Copy link
Contributor

So, @puneetlath, can we move forward and close the issue?

@puneetlath puneetlath changed the title [Wave 6: Workspace Chats] Make optimistic requests/IOUs/expense reports “hidden” [HOLD for payment 2023-11-16] [Wave 6: Workspace Chats] Make optimistic requests/IOUs/expense reports “hidden” Nov 13, 2023
@puneetlath
Copy link
Contributor Author

We just need to keep it open to pay @situchan after the regression period.

Upwork offer here: https://www.upwork.com/nx/wm/offer/27646351

@puneetlath
Copy link
Contributor Author

Paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

3 participants