-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-11-16] [Wave 6: Workspace Chats] Make optimistic requests/IOUs/expense reports “hidden” #29593
Comments
Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new. |
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue. |
I'm going to go ahead and remove the HOLD. I think it's fine for us to go ahead and implement this independent from the back-end changes. @mountiny is working on the back-end portion and until that is done, when the back-end responds it will overwrite the notification preference, so you'll need to test in offline mode @rezkiy37. |
I have to inform that starting tomorrow I have a short vocation until next Monday (6.11.2023). Feel free to left any comments, I will address them. See you soon 😉 |
This was merged. |
So, @puneetlath, can we move forward and close the issue? |
We just need to keep it open to pay @situchan after the regression period. Upwork offer here: https://www.upwork.com/nx/wm/offer/27646351 |
Paid. Thanks everyone! |
We want to make expense reports, IOU reports, and individual requests to use the same “hidden” setting that we use for threads so that they will be hidden from the LHN by default. Let's update the creation flows so that when these are optimistically created they have the "hidden" notification preference. This is described in the workspace chats design doc here.
Here for expense reports
Here for IOU reports
Here for individual requests
The text was updated successfully, but these errors were encountered: