Log in - There is no error message when trying to log in into an account with SAML required

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.85-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Pre-requisite: user must have previously configured SAML enabled and required for the account

1. Open New Expensify app
2. Enter email address
3. Tap on "Continue" button

Expected Result:

There should be an error message indicating that you cannot log into an account with SAML required

Actual Result:

No error message is displayed at all and the user is unable to log in

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Bug6240911_1697566943772.Ogtx2623_1_.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

cc @NikkiWines this sounds like #28372. However I believe it's already not possible to sign in on production with SAML required, so it might not be a blocker.

[francoisl]

Production asks you for a magic sign-in code and you can't sign in, so we can consider this a follow-up bug for SAML implementation. Going to remove the blocker label and reassign to Nikki.

[NikkiWines]

Yes, it's true you can't currently sign in on prod with SAML required but we previously showed an error message for this so the experience is somewhat confusing. This behavior is occurring because we're trying to roll out SAML sign in to users on desktop, web, and mweb but there's this logic in Web-E that prevents SAML required users from signing in.

For the moment I this is better than the current alternative because the redirect logic back to newDot for SAML users isn't working - so we shouldn't be auto-initiating that flow for SAML required users right now

[NikkiWines]

So yes this isn't a deploy blocker

[melvin-bot]

@johncschuster @NikkiWines this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[NikkiWines]

This should be handled with https://github.com/Expensify/Web-Expensify/pull/39419

[NikkiWines]

Closing now that https://github.com/Expensify/Web-Expensify/pull/39419 is on production