[HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] TaskDescriptionPage

[luacmartins]

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/tasks/TaskDescriptionPage.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019cc2c1cbf43ec7af
• Upwork Job ID: 1715041841053011968
• Last Price Increase: 2023-10-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019cc2c1cbf43ec7af

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @robertKozik (Internal)

[luacmartins]

SWM will work on this, no need for a proposal

[cdOut]

Hello! I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency and I would like to work on this task.

[melvin-bot]

Current assignee @robertKozik is eligible for the External assigner, not assigning anyone new.

[luacmartins]

@cdOut we have a draft PR!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] TaskDescriptionPage #30164

If no regressions arise, payment will be issued on 2023-11-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @robertKozik does not require payment (Contractor)
• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[robertKozik]

Does the BugZero Checklist apply here as well? Additionally, both @cdOut and I are contractors, so I believe there is no payment needed for this issue.

[MitchExpensify]

Do you think we should add a new regression test @robertKozik ?

[luacmartins]

Pending BZ checklist and payment

[MitchExpensify]

No payment is necessary here but I am still curious on whether we should add a new regression test @robertKozik 👀

[robertKozik]

Sorry 🙇🏼 I don't think we need regression test for it

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I don't think we need regression test for it
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[MitchExpensify]

All good! Thanks @robertKozik