Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$125] [Form Provider Refactor] ACHContractStep #30314

Closed
luacmartins opened this issue Oct 24, 2023 · 25 comments
Closed

[$125] [Form Provider Refactor] ACHContractStep #30314

luacmartins opened this issue Oct 24, 2023 · 25 comments
Assignees
@ntdiary @twisterdotcom @luacmartins @cdOut
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Oct 24, 2023 •
edited by twisterdotcom
Loading

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/ReimbursementAccount/ACHContractStep.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cc4521b1d4b152cc
  • Upwork Job ID: 1716963452301692928
  • Last Price Increase: 2023-10-26
Issue OwnerCurrent Issue Owner: @cdOut
@luacmartins luacmartins added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Oct 24, 2023
@luacmartins luacmartins self-assigned this Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01cc4521b1d4b152cc

@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as outdated.

Sign in to view
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (Internal)

@luacmartins
Copy link
Contributor Author

@cdOut will you be working on this issue too?

@cdOut
Copy link
Contributor

cdOut commented Oct 26, 2023

@luacmartins yes, I will be working on this issue.

@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Oct 26, 2023
@melvin-bot melvin-bot bot changed the title [Form Provider Refactor] ACHContractStep [$500] [Form Provider Refactor] ACHContractStep Oct 26, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

Current assignee @ntdiary is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 26, 2023
@luacmartins luacmartins changed the title [$500] [Form Provider Refactor] ACHContractStep [$125] [Form Provider Refactor] ACHContractStep Oct 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

Upwork job price has been updated to $125

@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@twisterdotcom
Copy link
Contributor

Waiting on a PR

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@cdOut
Copy link
Contributor

cdOut commented Oct 30, 2023

I am working on it, should create a PR soon

@cdOut cdOut mentioned this issue Oct 31, 2023
Closed
58 tasks
@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2023
@luacmartins
Copy link
Contributor Author

We have a draft PR

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 2, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 6, 2023

@ntdiary, @twisterdotcom, @luacmartins, @cdOut Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor Author

Still working on draft PR

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 7, 2023

@ntdiary @twisterdotcom @luacmartins @cdOut this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@cdOut
Copy link
Contributor

cdOut commented Nov 7, 2023

There are errors regarding the refactored elements in this specific flow that didn't appear before, I am still working on fixing them

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 13, 2023

@ntdiary, @twisterdotcom, @luacmartins, @cdOut Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 13, 2023

@ntdiary, @twisterdotcom, @luacmartins, @cdOut Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Nov 14, 2023
@twisterdotcom
Copy link
Contributor

Any update here @cdOut?

@twisterdotcom
Copy link
Contributor

Ah wait, I see: #30665 (comment)

@ntdiary
Copy link
Contributor

ntdiary commented Nov 17, 2023

Ah wait, I see: #30665 (comment)

@twisterdotcom, it looks like the refactoring has also been completed in another PR #30568. I noticed they modified the same code.

@cdOut
Copy link
Contributor

cdOut commented Nov 21, 2023

This issue was fixed in #30568, both flows were using a specific subform that had to be updated, so I had to update all the forms using it. This component is already refactored into FormProvider and is currently merged on main.

@twisterdotcom
Copy link
Contributor

Looks like this caused some deployblockers: #30568 (comment). I don't think we can call this done yet.

@twisterdotcom
Copy link
Contributor

Can we close this out now actually @cdOut and @luacmartins?

@cdOut
Copy link
Contributor

cdOut commented Dec 12, 2023

Yes, this is already merged and on main, as far as I'm concerned the deploy blockers were regarding different parts of form migration.

@luacmartins
Copy link
Contributor Author

Yea, we're good to close this one. Thanks everyone!

@blazejkustra blazejkustra mentioned this issue Jan 18, 2024
Merged
49 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 18, 2024
@blazejkustra blazejkustra mentioned this issue Feb 7, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntdiary ntdiary

@twisterdotcom twisterdotcom

@luacmartins luacmartins

@cdOut cdOut

Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ntdiary @twisterdotcom @luacmartins @cdOut