Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Chat - Parent message shows editing mode when editing the message in the thread #30488

Closed
5 of 6 tasks
izarutskaya opened this issue Oct 27, 2023 · 10 comments
Closed
5 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Oct 27, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.92.0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

  1. go to any chat
  2. send a message
  3. start thread
  4. hover over the message and click edit option
  5. without doing anything go back to parent clicking on the header

Expected Result:

Message should not be in edited mode

Actual Result:

Message is showing in edit mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6252642_1698369950159.Recording__163.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011db84558d8f19401
  • Upwork Job ID: 1717846962126123008
  • Last Price Increase: 2023-10-27
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 27, 2023
@melvin-bot melvin-bot bot changed the title Chat - Parent message shows editing mode when editing the message in the thread [$500] Chat - Parent message shows editing mode when editing the message in the thread Oct 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Job added to Upwork: https://www.upwork.com/jobs/~011db84558d8f19401

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@eh2077
Copy link
Contributor

eh2077 commented Oct 27, 2023

This is not a bug, see #28154

@mananjadhav
Copy link
Collaborator

This is not a bug, see #28154

@maddylewis @izarutskaya As pointed in the previous comment it looks like it was added in the PR. Can you confirm and then we can close this one.

Thanks @eh2077

@situchan
Copy link
Contributor

Discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1691673930838889?thread_ts=1689867403.367019&cid=C01GTK53T8Q

We can close as expected. Maybe we need to update Test Rail so QA team won't treat this as bug in the future.

@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@maddylewis
Copy link
Contributor

Maybe we need to update Test Rail so QA team won't treat this as bug in the future.

@situchan - which steps would you suggest adding/updating to test rail? i can create an issue to get that updated.

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@situchan
Copy link
Contributor

@situchan - which steps would you suggest adding/updating to test rail? i can create an issue to get that updated.

#21527 (comment)

@maddylewis
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants