Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-09] Can't write some symbols in newDot #30578

Closed
iwiznia opened this issue Oct 30, 2023 · 11 comments
Closed

[HOLD for payment 2023-11-09] Can't write some symbols in newDot #30578

iwiznia opened this issue Oct 30, 2023 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@iwiznia
Copy link
Contributor

iwiznia commented Oct 30, 2023

Steps:

  • Try to write (, ), [ (also * but seems like sometimes you can write it)
  • Check it does not get written

Happening on web staging but not on web production, so must be something we deployed to staging, thus we need to block deploy.

@iwiznia iwiznia added DeployBlockerCash This issue or pull request should block deployment Engineering Bug Something is broken. Auto assigns a BugZero manager. labels Oct 30, 2023
@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 30, 2023
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Oct 30, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@ishpaul777
Copy link
Contributor

ishpaul777 commented Oct 30, 2023

will be fixed in #30559

cc @HardikChoudhary24 @aimane-chnaif

@Beamanator
Copy link
Contributor

Beamanator commented Oct 31, 2023

Fix was CP'd 👍

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Oct 31, 2023
@melvin-bot melvin-bot bot changed the title Can't write some symbols in newDot [HOLD for payment 2023-11-07] Can't write some symbols in newDot Oct 31, 2023
Copy link

melvin-bot bot commented Oct 31, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

Copy link

melvin-bot bot commented Oct 31, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [] The PR that introduced the bug has been identified. Link to the PR:
  • [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [] Determine if we should create a regression test for this bug.
  • [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 2, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-11-07] Can't write some symbols in newDot [HOLD for payment 2023-11-09] [HOLD for payment 2023-11-07] Can't write some symbols in newDot Nov 2, 2023
Copy link

melvin-bot bot commented Nov 2, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

Copy link

melvin-bot bot commented Nov 2, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [] The PR that introduced the bug has been identified. Link to the PR:
  • [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [] Determine if we should create a regression test for this bug.
  • [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@lschurr lschurr changed the title [HOLD for payment 2023-11-09] [HOLD for payment 2023-11-07] Can't write some symbols in newDot [HOLD for payment 2023-11-09] Can't write some symbols in newDot Nov 2, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 7, 2023
@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 7, 2023
@lschurr
Copy link
Contributor

lschurr commented Nov 7, 2023

Payment for this is happening over here: #28149

@lschurr lschurr closed this as completed Nov 7, 2023
@aimane-chnaif
Copy link
Contributor

@lschurr can you please help with my payment here?
I was not involved in original issue / PR but just reviewed PR which fixes this issue which was deploy blocker.

@lschurr
Copy link
Contributor

lschurr commented Nov 10, 2023

Thanks! Can you apply here @aimane-chnaif - https://www.upwork.com/jobs/~01cfb8e70d95e95640

@lschurr lschurr reopened this Nov 10, 2023
@lschurr
Copy link
Contributor

lschurr commented Nov 10, 2023

Paid and closed.

@lschurr lschurr closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants