-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus mode showing tons of unread reports that I have no idea why are there #30781
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @arosiclair ( |
Agree this is a deploy blocker. For me, all of the unread reports are of type chat report. And I'm pretty sure some at least one of them cannot have had an IOU shared between them (Clem). Additionally, @iwiznia is one of my broken chats, but I am not one of his broken chats... |
@Beamanator FYI new blocker |
Not seeing this with my expensify or my expensifail accounts. I'm attending an interview atm so can't really investigate. Can one of you take over on this? @iwiznia @Julesssss or anyone? |
Not me, sorry. |
Sorry, I'm also busy and only have an hour left in my day. |
@Julesssss the green dot issue is likely this issue which I'm working on #30775 |
Oh nice. Thanks, I didn't see that issue. |
I also can't reproduce this on my account, I'll check my expensifail now ya can't reproduce there either... We're gunna need more info @iwiznia or more people experiencing this |
Asked for any others that are seeing this issue here. If we don't have many people experiencing this, let's remove the blocker label. I also do not see any PR's in this deploy that could've caused this. |
Are we just talking about archived ones? And are we sure that someone did not just delete a workspace that @iwiznia is on?
I am confused about why they would not show on production. Archived unread chats currently will show on production IIRC. So, it's expected - but we're changing that behavior here - #30795 |
To add to what @marcaaron said, I think this is a duplicate of https://github.com/Expensify/Expensify/issues/325443 (the PR he linked is an initial fix for that issue). |
Groovy so I'll remove the blocker label for now, while y'all decide if we should close this or not :D |
Ionatan's unread chats are mostly archived chat reports. @iwiznia are you not able to see those on Production? Yes, it is known bug https://github.com/Expensify/Expensify/issues/325443 |
Is it really just us two that are facing this? One thing me and @iwiznia have in common is that we both worked on the very first IOU reports and probably have a lot of malformed reports in our accounts... |
@MonilBhavsar I see the same as @iwizni, and yes only on staging. |
So we removed the deploy blocker because we believe no one except me and Jules will experience this? Also, if you check my screenshot you can see it is not only archived chats, the 3rd and 4th chat in the list seem like just empty chats (workspace chat?) with people I never spoke to... |
To clear things up @Julesssss issue was with GBR's not unread reports and it should be fixed by the other issue. @iwiznia's unread reports issue seems to be 99% dupe of https://github.com/Expensify/Expensify/issues/325443. For the non-archived workspace chats I'm not sure (though it might be the same root cause as the archived problem). Is there something special about those chats @iwiznia? Do you know of any way to reproduce them? |
Bump @iwiznia ^ |
Nothing special I can tell and no, I have no idea how to reproduce this |
Hm okay well it sounds like we should just try again the next time this happens. Once the other issues get closed out, this should largely be solved too. Closing this out for now... |
Some context https://expensify.slack.com/archives/C049HHMV9SM/p1698933470963439?thread_ts=1698924304.893529&cid=C049HHMV9SM
Happening on staging but not prod (only tested web).
I see a ton of unread chats on focus mode that should not be shown at all
The text was updated successfully, but these errors were encountered: