Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus mode showing tons of unread reports that I have no idea why are there #30781

Closed
iwiznia opened this issue Nov 2, 2023 · 22 comments
Closed
Assignees

Comments

@iwiznia
Copy link
Contributor

iwiznia commented Nov 2, 2023

Some context https://expensify.slack.com/archives/C049HHMV9SM/p1698933470963439?thread_ts=1698924304.893529&cid=C049HHMV9SM

Happening on staging but not prod (only tested web).
I see a ton of unread chats on focus mode that should not be shown at all

image

@iwiznia iwiznia added the DeployBlockerCash This issue or pull request should block deployment label Nov 2, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 2, 2023

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Julesssss
Copy link
Contributor

Agree this is a deploy blocker.

For me, all of the unread reports are of type chat report. And I'm pretty sure some at least one of them cannot have had an IOU shared between them (Clem). Additionally, @iwiznia is one of my broken chats, but I am not one of his broken chats...

Screenshot 2023-11-02 at 14 35 14

@Julesssss
Copy link
Contributor

@Beamanator FYI new blocker

@arosiclair
Copy link
Contributor

Not seeing this with my expensify or my expensifail accounts. I'm attending an interview atm so can't really investigate. Can one of you take over on this? @iwiznia @Julesssss or anyone?

@iwiznia
Copy link
Contributor Author

iwiznia commented Nov 2, 2023

Not me, sorry.
BTW you can still work while attending the interview, you don't have to be looking at what they are doing for 1 hour...

@Julesssss
Copy link
Contributor

Sorry, I'm also busy and only have an hour left in my day.

@puneetlath
Copy link
Contributor

@Julesssss the green dot issue is likely this issue which I'm working on #30775

@Julesssss
Copy link
Contributor

Oh nice. Thanks, I didn't see that issue.

@Beamanator
Copy link
Contributor

Beamanator commented Nov 2, 2023

I also can't reproduce this on my account, I'll check my expensifail now

ya can't reproduce there either... We're gunna need more info @iwiznia or more people experiencing this

@arosiclair
Copy link
Contributor

Asked for any others that are seeing this issue here. If we don't have many people experiencing this, let's remove the blocker label. I also do not see any PR's in this deploy that could've caused this.

@marcaaron
Copy link
Contributor

unread chats on focus mode that should not be shown at all

Are we just talking about archived ones? And are we sure that someone did not just delete a workspace that @iwiznia is on?

Happening on staging but not prod (only tested web).

I am confused about why they would not show on production. Archived unread chats currently will show on production IIRC.

So, it's expected - but we're changing that behavior here - #30795

@sakluger
Copy link
Contributor

sakluger commented Nov 2, 2023

To add to what @marcaaron said, I think this is a duplicate of https://github.com/Expensify/Expensify/issues/325443 (the PR he linked is an initial fix for that issue).

@Beamanator
Copy link
Contributor

Groovy so I'll remove the blocker label for now, while y'all decide if we should close this or not :D

@Beamanator Beamanator added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 3, 2023
@MonilBhavsar
Copy link
Contributor

Ionatan's unread chats are mostly archived chat reports. @iwiznia are you not able to see those on Production? Yes, it is known bug https://github.com/Expensify/Expensify/issues/325443

@Julesssss
Copy link
Contributor

Is it really just us two that are facing this? One thing me and @iwiznia have in common is that we both worked on the very first IOU reports and probably have a lot of malformed reports in our accounts...

@Julesssss
Copy link
Contributor

Julesssss commented Nov 3, 2023

@MonilBhavsar I see the same as @iwizni, and yes only on staging.

@iwiznia
Copy link
Contributor Author

iwiznia commented Nov 3, 2023

So we removed the deploy blocker because we believe no one except me and Jules will experience this?

Also, if you check my screenshot you can see it is not only archived chats, the 3rd and 4th chat in the list seem like just empty chats (workspace chat?) with people I never spoke to...

@arosiclair
Copy link
Contributor

To clear things up @Julesssss issue was with GBR's not unread reports and it should be fixed by the other issue.

@iwiznia's unread reports issue seems to be 99% dupe of https://github.com/Expensify/Expensify/issues/325443.

For the non-archived workspace chats I'm not sure (though it might be the same root cause as the archived problem). Is there something special about those chats @iwiznia? Do you know of any way to reproduce them?

@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@arosiclair
Copy link
Contributor

Bump @iwiznia ^

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@iwiznia
Copy link
Contributor Author

iwiznia commented Nov 7, 2023

Nothing special I can tell and no, I have no idea how to reproduce this

@arosiclair
Copy link
Contributor

Hm okay well it sounds like we should just try again the next time this happens. Once the other issues get closed out, this should largely be solved too. Closing this out for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants