[Unvalidated Sign-Up] Allow new account sign ins to not require account validation in NewDot

[johnmlee101]

We want to replicate the similar flows as OldDot, where you can access the site without entering a validateCode or using Google.

Right now we fully support unvalidated accounts since you can sign into OldDot, deep link from the chat bubble into NewDot, then you can use it just fine.

EDIT:

As an added bonus to this change, we will remove the very first "Here's your magic sign-in link" for both OldDot and NewDot since the user is brought straight into product.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e9ff00ed2a89df20
• Upwork Job ID: 1790695759605694464
• Last Price Increase: 2024-05-15

[melvin-bot]

@johnmlee101 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@johnmlee101 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@johnmlee101 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[tjferriss]

@johnmlee101 what is the latest here?

[johnmlee101]

Need to check in on this https://github.com/Expensify/Expensify/issues/281559 and https://github.com/Expensify/Expensify/issues/279833

[melvin-bot]

@johnmlee101 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[tjferriss]

@johnmlee101 what is the latest here? Also, are the public emails who sign up on expensify.com and get the classicRedirect NVP to new.expensify.com also receiving this magic sign-in email upon sign up?

[johnmlee101]

Also, are the public emails who sign up on expensify.com and get the classicRedirect NVP to new.expensify.com also receiving this magic sign-in email upon sign up?

I haven't confirmed this one yet, would need to try on a personal account

Latest is there's some spread work and confusion about what we need to do. My existing PR needs to be closed and the other taken over

[melvin-bot]

@johnmlee101 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johnmlee101 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[francoisl]

are the public emails who sign up on expensify.com and get the classicRedirect NVP to new.expensify.com also receiving this magic sign-in email upon sign up?

At the moment, no. We just redirect you to NewDot after you click "Join" and you're signed in. No magic sign-in email gets sent.

[melvin-bot]

@johnmlee101 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@johnmlee101 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@johnmlee101 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

This issue has not been updated in over 14 days. @johnmlee101 eroding to Weekly issue.

[melvin-bot]

This issue has not been updated in over 15 days. @johnmlee101 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[danielrvidal]

This is in review in review so I think we're making progress here: https://github.com/Expensify/Web-Expensify/pull/42216

[techievivek]

Adding Rushat(C+) to GH since he helped review the App PR.

[sakluger]

Hey folks, I got a payment issue (GH) for the linked PR on this issue (PR). Will someone be handling payment here, or should I handle payment in my issue?

[rushatgabhane]

@sakluger here is fine

[JmillsExpensify]

Can I get a payment summary so that I can approve payment?

[mallenexpensify]

We're handling payment in this issue. Looks like Rushat's the only one due payment. @thesahindia , I see you're assigned but it doesn't look like you've reviewed the PR, comment if you believe you're due compensation.

Contributor+: @rushatgabhane due $250 via NewDot.

Do we need a regression test for this or will it be added somewhere else?

[JmillsExpensify]

$250 approved for @rushatgabhane

[melvin-bot]

@danielrvidal, @mallenexpensify, @rushatgabhane, @techievivek, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[danielrvidal]

@mallenexpensify do you know if this one still needs to be open. I don't think it's actually assigned to me but I was watching it as we prepared for XeroCon, but I think this is done but am not sure.

[mallenexpensify]

I'm going to close and assume a regression test will be handled elsewhere, if needed. Comment/reopen if you disagree. cc @johnmlee101 since you drafted the OP.