[HOLD for payment 2023-11-13] Expense - Workspace avatar and name change after creating a workspace expense

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.95.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace chat.
4. Click + > Request money.
5. Create a manual request.

Expected Result:

The workspace avatar and name in the expense preview match the actual workspace avatar and name.

Actual Result:

The workspace avatar and name in the expense preview change. The name is changed to the requester name.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6262296_1699019059636.20231103_210231.mp4

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dangrous]

I'm guessing it might be related to #30591 but I'm confirming (running into a crash prior to creating a money request on dev so haven't been able to test yet)

[dangrous]

nope, not #30591. Although the optimistic data IS weird, it's not related to this bug. Looking more.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[s-alves10]

Looks like a regression of this PR

[s-alves10]

This change is the source of this issue

[dangrous]

Nicely found, @s-alves10 . Looks like changing that to:

    const primaryDisplayName = isWorkspaceActor ? displayName : ReportUtils.getDisplayNameForParticipant(actorAccountID);

works well, though I need to see if there are any unexpected consequences there

[dangrous]

I'm going to go ahead and put up a PR with that ^ solution, since we haven't heard anything from the PR authors. I'm going to be AFK for a couple hours (driving to the airport) so I figure that's a good next step in the meantime

[lukemorawski]

@dangrous are you creating a PR for this, or should I prepare that quick fix PR?

[dangrous]

Yep, I grabbed it here - #30342

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show displayName in IOU if the primary actor is a workspace #30862

If no regressions arise, payment will be issued on 2023-11-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dangrous]

@joekaufmanexpensify - adding bug zero to assist with payment for reviewer of linked PR! I think that's all we need

[joekaufmanexpensify]

Sure, happy to help!

[joekaufmanexpensify]

Only payment due here is $500 to @0xmiroslav for review of the internal PR. Paid via NewDot.

[joekaufmanexpensify]

@0xmiroslav could you please request $500 and confirm here once complete?

[0xmiros]

Let's close this. I am tracking myself. Thanks

[joekaufmanexpensify]

Sounds good. TY!