[HOLD for payment 2023-11-30] Add Required fields to MoneyRequestConfirmationList

[cead22]

• Design Doc
• Update MenuItem.js
  • Let's add a prop rightLabel
  • Let's add code similar to the snippet below above the line {Boolean(props.shouldShowRightIcon) &&
• Update MoneyRequestConfirmationList.js where we’ll show the category/tag/tax menu items
  • Let's pass the new prop rightLabel={permissions.canUseViolations() && Boolean(props.policy.requiresCategory) ? translate('required') : ''} to the MenuItem used for categories
  • Let's do the same for tags rightLabel={permissions.canUseViolations() && Boolean(props.policy.requiresTag) ? translate('required') : ''}
  • permissions.canUseViolations will be implemented in Implement new component ReceiptEmptyState #30663

{Boolean(props.rightLabel) && (
    <View style={[styles.popoverMenuIcon, styles.pointerEventsAuto]}>
        <Text>{props.rightLabel}</Text>
    </View>
)}

[cead22]

@lindboe @cdanwards can you comment here so I can assign you?

[cdanwards]

Commenting for assignment

[melvin-bot]

@cdanwards Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@cdanwards Whoops! This issue is 2 days overdue. Let's get this updated quick!

[cdanwards]

Getting PR up now.

[cdanwards]

This PR was merged!

[cead22]

Wohoo 🎉

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Adds Violations Requirements to MoneyRequestConfirmationList #31380

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cdanwards does not require payment (Contractor)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[cead22]

Looks like this wasn't the cause of the blocker (thanks @luacmartins). It was the fact that policy wasn't available when splitting a bill with a Workspace

[situchan]

@cead22 can you please reopen & add New feature label for payment? Thanks

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[cead22]

Do I need to close it again?

[adelekennedy]

Payouts due:

Contributor+: $500 @situchan

Upwork job is here.

[adelekennedy]

payment made