[HOLD for payment 2023-12-07] [Wave 6: Tags] Limit tag list to 500 items

[puneetlath]

Looks like we forgot to implement this when we were implementing tags. As discussed in the doc, if there are more than 500 tags, we only want to show the first 500. This also applies to search, where we should only show the first 500 results.

[melvin-bot]

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[puneetlath]

@dannymcclain could you help us out with a mockup of what we should show in the UI when we're only showing 500 out of the total?

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[rezkiy37]

Melvin, no overdue here.

[dannymcclain]

Not overdue Melvin—should be able to get started on this today.

[dannymcclain]

Based on this slack convo, we're going to see what proposals for a show more option look like, but if that option is overly complicated/too much effort, we'll roll with a simple message.

Show more (Figma)

Help message (Figma)

[puneetlath]

@rezkiy37 mind posting a proposal here of how you'd go about implementing the "show more" option? Do you think it would be very complicated?

I guess we already use it here, so it shouldn't be too hard:

[rezkiy37]

Adding the button to the list is not a big deal 😉

[puneetlath]

Sweet, let's do it.

[rezkiy37]

@puneetlath, @dannymcclain, do you have a workspace with many tags?

[puneetlath]

Just capturing some things we discussed in Slack:

1. I gave @rezkiy37 a policy that has ~10k tags
2. We'll use the "show more" on all optionlists (categories, tags, etc) when they have more than 500 items

[rezkiy37]

Actively working on the issue.

[rezkiy37]

Guys, let's decide which position variant we would like to use for the "show more" button: fixed or floating?

Fixed.mp4

Floating.mp4

cc @puneetlath, @dannymcclain

[dannymcclain]

Definitely floating. 💯

The show more button is only relevant once you reach the end of the list, so it should just stay tucked away down there.

cc @Expensify/design

[shawnborton]

Yup, works for me!

While I'm here... the opening sentence in this page could use a period at the end.

[rezkiy37]

@shawnborton, do you mean "Showing 10 of 100."?

[shawnborton]

Nope, the "Select a tag..." line here:

[rezkiy37]

So, then for the category page as well.

[rezkiy37]

Daily updates: I am polishing and testing the new feature. Planing to start review process tomorrow.

[shawnborton]

Correct, thanks!

[rezkiy37]

Just finished with development. Preparing the PR.

[rezkiy37]

Guys, should we close this issue?

[puneetlath]

We still need the issue for paying out @rushatgabhane when the PR hits prod.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Limit tag list to 500 items #31447

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @rezkiy37 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

This is not so much a bug as something we forgot to implement, so no checklist needed here. Here's an issue for adding the regression test: https://github.com/Expensify/Expensify/issues/342802

Payment summary:

• C+ @rushatgabhane - $500

@rushatgabhane please request on NewDot.

[JmillsExpensify]

$500 payment approved for @rushatgabhane based on comment above.