Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-07] [$125] [Form Provider Refactor] AddPersonalBankAccountPage #31562

Closed
luacmartins opened this issue Nov 20, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Nov 20, 2023

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/AddPersonalBankAccountPage.js

cc @kowczarz @cdOut

Note: this component also needs to be migrated to a functional component!

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018c3f82c1a205bb8d
  • Upwork Job ID: 1726651775799279616
  • Last Price Increase: 2023-11-28
Issue OwnerCurrent Issue Owner: @kowczarz
@luacmartins luacmartins added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Nov 20, 2023
@luacmartins luacmartins self-assigned this Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018c3f82c1a205bb8d

Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

This comment was marked as off-topic.

Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (Internal)

@luacmartins
Copy link
Contributor Author

@cdOut @kowczarz are either of you available to work on this one?

@melvin-bot melvin-bot bot added the Overdue label Nov 27, 2023
@luacmartins
Copy link
Contributor Author

bump @cdOut @kowczarz

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
@kowczarz
Copy link
Contributor

Hey! I'm from software mansion and I would like to work on this task

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 28, 2023
@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Nov 28, 2023
@melvin-bot melvin-bot bot changed the title [Form Provider Refactor] AddPersonalBankAccountPage [$500] [Form Provider Refactor] AddPersonalBankAccountPage Nov 28, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 28, 2023
@luacmartins luacmartins changed the title [$500] [Form Provider Refactor] AddPersonalBankAccountPage [$125] [Form Provider Refactor] AddPersonalBankAccountPage Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

Upwork job price has been updated to $125

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Nov 30, 2023
@melvin-bot melvin-bot bot changed the title [$125] [Form Provider Refactor] AddPersonalBankAccountPage [HOLD for payment 2023-12-07] [$125] [Form Provider Refactor] AddPersonalBankAccountPage Nov 30, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 30, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
  • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@situchan] Determine if we should create a regression test for this bug.
  • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 7, 2023
@slafortune
Copy link
Contributor

@slafortune
Copy link
Contributor

Paid!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants