Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-07] [Theme Switching Migration] Auth2FA Batch #31680

Closed
4 tasks
grgia opened this issue Nov 22, 2023 · 15 comments
Closed
4 tasks

[HOLD for payment 2023-12-07] [Theme Switching Migration] Auth2FA Batch #31680

grgia opened this issue Nov 22, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Nov 22, 2023

Part of #31677

As part of the Theme Switching Project, we need to migrate the following:

  • AnimatedStep/index.js
  • OfflineIndicator.js
  • PressableWithDelayToggle.tsx
  • GenericPressable/BaseGenericPressable.tsx (is used in PressableWithDelayToggle)
@grgia grgia self-assigned this Nov 22, 2023
@grgia grgia converted this from a draft issue Nov 22, 2023
@grgia grgia added the Daily KSv2 label Nov 22, 2023
@koko57
Copy link
Contributor

koko57 commented Nov 22, 2023

leaving a comment to be assigned :)

@keisyrzk
Copy link
Contributor

Hello!
I'm Krzysztof from Callstack - an expert contributor group and I would like to work on this one.

Copy link

melvin-bot bot commented Nov 22, 2023

📣 @keisyrzk! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@keisyrzk keisyrzk mentioned this issue Nov 22, 2023
47 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 24, 2023
@grgia grgia moved this from Todo to In Progress in Theme Switching / Light Mode Nov 27, 2023
@s77rt
Copy link
Contributor

s77rt commented Nov 28, 2023

@grgia Can you please assign me here?

@grgia grgia moved this from In Progress to Merged in Theme Switching / Light Mode Nov 29, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 30, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching Migration] Auth2FA Batch [HOLD for payment 2023-12-07] [Theme Switching Migration] Auth2FA Batch Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@koko57
Copy link
Contributor

koko57 commented Nov 30, 2023

@mountiny please add @keisyrzk to the Contractors list 🙂 Melvin doesn't know yet he's from Callstack

@mountiny
Copy link
Contributor

Made a PR for that

@grgia grgia moved this from Merged to Done - Live ✅ in Theme Switching / Light Mode Dec 6, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 12, 2023

@s77rt, @keisyrzk, @koko57, @grgia Huh... This is 4 days overdue. Who can take care of this?

@grgia grgia added the NewFeature Something to build that is a new item. label Dec 13, 2023
Copy link

melvin-bot bot commented Dec 13, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Dec 13, 2023
@grgia
Copy link
Contributor Author

grgia commented Dec 13, 2023

hey @miljakljajic could you help me out with the $500 C+ review payment to @s77rt?

@miljakljajic
Copy link
Contributor

contract sent @s77rt !

@s77rt
Copy link
Contributor

s77rt commented Dec 13, 2023

@miljakljajic Accepted! Thanks!

@miljakljajic
Copy link
Contributor

Paid! Thank you for your work @s77rt

Seems like @keisyrzk and @koko57 are both from callstack, so are we good to close - no further payments?

@miljakljajic
Copy link
Contributor

Closing!

@github-project-automation github-project-automation bot moved this from Done - Live ✅ to Merged in Theme Switching / Light Mode Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants