Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-07] [Theme Switching Migration] Report(Chat) Batch #31682

Closed
9 tasks
grgia opened this issue Nov 22, 2023 · 8 comments
Closed
9 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Nov 22, 2023

Part of #31677

As part of the Theme Switching Project, we need to migrate the following:

  • ReportActionItemGrouped.js
  • ReportActionItemSingle.js
  • BaseHTMLEngineProvider.js
  • PDFView/index.js
  • InlineSystemMessage.tsx
  • AttachmentViewPdf/index.android.js
  • src/styles/getContextMenuItemStyles/index.native.ts
  • src/styles/getContextMenuItemStyles/index.ts
  • src/components/MenuItem.js
@grgia grgia converted this from a draft issue Nov 22, 2023
@grgia grgia self-assigned this Nov 22, 2023
@grgia grgia added the Daily KSv2 label Nov 22, 2023
@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@koko57
Copy link
Contributor

koko57 commented Nov 22, 2023

leaving a comment to be also assigned :)

@koko57
Copy link
Contributor

koko57 commented Nov 22, 2023

We can add these files to this batch:
AttachmentViewPdf/index.android.js
src/styles/getContextMenuItemStyles/index.native.ts
src/styles/getContextMenuItemStyles/index.ts
src/components/MenuItem.js

@grgia
Copy link
Contributor Author

grgia commented Nov 22, 2023

thanks! Updated description @koko57

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 23, 2023
@grgia grgia moved this from Todo to In Progress in Theme Switching / Light Mode Nov 27, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 29, 2023
@grgia grgia moved this from In Progress to Merged in Theme Switching / Light Mode Nov 29, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 30, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching Migration] Report(Chat) Batch [HOLD for payment 2023-12-07] [Theme Switching Migration] Report(Chat) Batch Nov 30, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @koko57 does not require payment (Contractor)

@grgia grgia moved this from Merged to Done - Live ✅ in Theme Switching / Light Mode Dec 6, 2023
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 7, 2023
Copy link

melvin-bot bot commented Dec 12, 2023

@koko57, @grgia Huh... This is 4 days overdue. Who can take care of this?

@grgia grgia closed this as completed Dec 13, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2023
@github-project-automation github-project-automation bot moved this from Done - Live ✅ to Merged in Theme Switching / Light Mode Dec 13, 2023
@grgia grgia moved this from Merged to Done - Live ✅ in Theme Switching / Light Mode Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
No open projects
Status: Done - Live
Development

No branches or pull requests

3 participants