[HOLD for payment 2023-12-14] [$500] Web - Emojis - Flags category is missing on Emoji picker screen

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.2.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to stsaging.new.expensify.com
2. Navigate to any conversation
3. Open emoji picker and check emoji categories

Expected Result:

Flags category should be ordered in the list of emoji categories

Actual Result:

Flags category is missing on Emoji picker screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012c3f161bd9db1ab3

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Flags category is missing in EmojiPicker on Windows web

What is the root cause of that problem?

We intentionally disabled the flags category in this PR since Windows doesn't support them.

What changes do you think we should make in order to solve the problem?

Now that we have new emoji fonts for Windows, flags are shown as below

If this is acceptable, we can update the code

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Lines 76 to 79 in 704f3f7

	const filteredEmojis =
	getOperatingSystem() === CONST.OS.WINDOWS
	? EmojiUtils.mergeEmojisWithFrequentlyUsedEmojis(emojiAssets.slice(0, flagHeaderIndex))
	: EmojiUtils.mergeEmojisWithFrequentlyUsedEmojis(emojiAssets);

to

        const filteredEmojis = EmojiUtils.mergeEmojisWithFrequentlyUsedEmojis(emojiAssets);

What alternative solutions did you explore? (Optional)

[aimane-chnaif]

This is not worth fixing. Flags are also different.

[s-alves10]

@aimane-chnaif

When a iphone user sends a flags emoji to a Windows user, the Windows user is still able to see the flags emoji(as in the screenshot in my proposal).

A user can receive flags emoji, but can't send flags emoji. I think this is worth fixing

cc @c3024 @puneetlath

[puneetlath]

Now that we have new emoji fonts for Windows

What do you mean by this @s-alves10?

[s-alves10]

I mean we recently introduced a new emoji fonts for Windows
https://github.com/Expensify/App/blob/main/assets/fonts/web/seguiemj.ttf

I guess that the the flags category was disabled since the Windows fonts doesn't support them

[melvin-bot]

@puneetlath, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[c3024]

A user can receive flags emoji, but can't send flags emoji. I think this is worth fixing

I think this makes sense.

I think users likely search for flags with country name so even though it just shows letters for most flags on Windows, it kinda serves the purpose. The user on the other side can see the sent flag emojis.

New_Expensify_-_Google_Chrome_2023-11-30_20-46-05-2023-11-30.15_18_11.245.mp4

So, I think this is worth fixing. Shall we proceed with fixing this issue? @puneetlath

[aimane-chnaif]

It's a bit confusing for users since it looks like bolded text in header.
Maybe @Expensify/design can confirm if it should be fixed or not worth

[c3024]

I think the confusion majorly arises when a non-Windows user sends a flag emoji to a Windows user. The Windows user sees letters and it could be misunderstood as a text message.

But this behaviour already exists. Non-windows users can send flag emojis to Windows users now.

If we allow sending flag emojis from Windows devices, the Windows user selects a flag emoji and sends it. So, showing the letters in place of flag emoji for the Windows user sending the flag emoji then will not be confusing.

[shawnborton]

Sorry, what exactly is the bug? Is it the emoji picker missing a section for flags, or the fact that flags don't render as flags on Windows?

[c3024]

Emoji picker missing the section for flags.

[shawnborton]

Got it. I don't feel too strongly, we already have a flag icon in our library as I thought we already had this section in place. So if we do decide to add it, we at least already have the icon for that section. Might need to make the picker wider on desktop though to account for the extra tab item.

Curious if @puneetlath thinks this is worth fixing or not though.

[puneetlath]

I think I'm cool re-adding support for it. It removes some platform specific code and just makes things more consistent, so I say we go for it.

[s-alves10]

@c3024

PR is ready for review #32396

[s-alves10]

Pay day here would be 14 Dec. @puneetlath

[puneetlath]

Ah thanks. Not sure why the automation didn't work.

@s-alves10 @c3024 sent you both offers.

[s-alves10]

@puneetlath Accepted. Thanks

[puneetlath]

All paid.