Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-05] [$250] [TS migration] Migrate 'ReportActionItemCreated.js' component to TypeScript #31966

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 30 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/home/report/ReportActionItemCreated.js 22
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012a80490ec74e6e5a
  • Upwork Job ID: 1744724267346472960
  • Last Price Increase: 2024-01-09
  • Automatic offers:
    • Tony-MK | Contributor | 28092356
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. labels Jan 9, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ReportActionItemCreated.js' component to TypeScript [$500] [TS migration] Migrate 'ReportActionItemCreated.js' component to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012a80490ec74e6e5a

Copy link
Author

melvin-bot bot commented Jan 9, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Monthly KSv2 labels Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2024
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'ReportActionItemCreated.js' component to TypeScript [$250] [TS migration] Migrate 'ReportActionItemCreated.js' component to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Upwork job price has been updated to $250

@DylanDylann
Copy link
Contributor

I am happy to work on this issue

@esh-g
Copy link
Contributor

esh-g commented Jan 9, 2024

I'm available to work on this issue!

@yh-0218
Copy link
Contributor

yh-0218 commented Jan 9, 2024

I'd like to work on it.

@vadymbokatov
Copy link
Contributor

Hi I would like to work on this please.

@ghost
Copy link

ghost commented Jan 9, 2024

I am interested to work on it

@rayane-djouah
Copy link
Contributor

I would like to work on this

1 similar comment
@shahinyan11
Copy link

I would like to work on this

@Tony-MK
Copy link
Contributor

Tony-MK commented Jan 9, 2024

Love to work on this

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 10, 2024
Copy link
Author

melvin-bot bot commented Jan 10, 2024

📣 @Tony-MK 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny
Copy link
Contributor

Assigning @Tony-MK since thats a first contributor without active TS issues

@Tony-MK
Copy link
Contributor

Tony-MK commented Jan 13, 2024

Hey @Santhosh-Sellavel,

The PR is ready for review.

Thank you. 😄

Copy link
Author

melvin-bot bot commented Jan 23, 2024

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hayata-suenaga
Copy link
Contributor

RP was merged

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 29, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'ReportActionItemCreated.js' component to TypeScript [HOLD for payment 2024-02-05] [$250] [TS migration] Migrate 'ReportActionItemCreated.js' component to TypeScript Jan 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 29, 2024
Copy link
Author

melvin-bot bot commented Jan 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Jan 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Jan 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@Santhosh-Sellavel
Copy link
Collaborator

This is just migration, no regression tests are needed here.
@laurenreidexpensify Can you leave the payment summary message?

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 5, 2024
@laurenreidexpensify
Copy link
Contributor

Payment Summary:

@Santhosh-Sellavel
Copy link
Collaborator

Requested on ND

@JmillsExpensify
Copy link

$250 approved for @Santhosh-Sellavel based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests