[HOLD for payment 2024-02-05] [HOLD for payment 2024-01-26] [TS migration] Migrate 'SelectionList' component to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/SelectionList/selectionListPropTypes.js	3
src/components/SelectionList/index.js	4
src/components/SelectionList/index.ios.js	3
src/components/SelectionList/index.android.js	3
src/components/SelectionList/UserListItem.js	8
src/components/SelectionList/RadioListItem.js	5
src/components/SelectionList/BaseSelectionList.js	26
src/components/SelectionList/BaseListItem.js	16

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[filip-solecki]

Hey! I’m Filip Solecki from Software Mansion, an expert agency, and I’d like to continue work on this issue!

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[mountiny]

I believe Jasper has still been ooo so going to help pushing this forwards

[jasperhuangg]

I'm back @mountiny I can help out here, thanks for looking out!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'SelectionList' component to TypeScript #34008

If no regressions arise, payment will be issued on 2024-01-26. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @SzymczakJ does not require payment (Contractor)
• @filip-solecki does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[Julesssss]

This was eventually reverted. Here's the new PR

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'SelectionList' component to TypeScript #34794

If no regressions arise, payment will be issued on 2024-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @SzymczakJ does not require payment (Contractor)
• @filip-solecki does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @jliexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $500 via NewDot
• Contributor: @SzymczakJ is from an agency-contributor and not due payment
• Contributor: @filip-solecki is from an agency-contributor and not due payment

BugZero Checklist (@jliexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jliexpensify]

@Julesssss can I confirm - @allroundexperts should be paid $250 as it's a TS Migration right?

Also, I need to create a new Upworks job + is there a checklist to complete?

[Julesssss]

Melvin made a huge mess of assignments here, bad bot 🔨

@jliexpensify yes, looking at other payments, I believe so 👍

[jliexpensify]

Payment Summary:

• Contributor: @filip-solecki (invoiced)
• Contributor: @SzymczakJ (invoiced)
• C+: @allroundexperts $250 (request on New.Dot)

[JmillsExpensify]

$250 approved for @allroundexperts based on summary above.