Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-15] [$250] [TS migration] Migrate 'NewChatSelector' page to TypeScript #31989

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 40 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/NewChatSelectorPage.js 14
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015f7a31fb067d1392
  • Upwork Job ID: 1744724669137395712
  • Last Price Increase: 2024-01-09
  • Automatic offers:
    • MahmudjonToraqulov | Contributor | 28092406
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. labels Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'NewChatSelector' page to TypeScript [$500] [TS migration] Migrate 'NewChatSelector' page to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015f7a31fb067d1392

@melvin-bot melvin-bot bot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Monthly KSv2 labels Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2024
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'NewChatSelector' page to TypeScript [$250] [TS migration] Migrate 'NewChatSelector' page to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Upwork job price has been updated to $250

@DylanDylann
Copy link
Contributor

I would like to take this issue

@rayane-djouah
Copy link
Contributor

I would like to work on this

@MahmudjonToraqulov
Copy link
Contributor

I'd like to work on it.

@Tony-MK
Copy link
Contributor

Tony-MK commented Jan 9, 2024

I would like work on this

@ishpaul777
Copy link
Contributor

I'd like to work on it.

@vadymbokatov
Copy link
Contributor

Hi I would like to work on this please.

@yh-0218
Copy link
Contributor

yh-0218 commented Jan 9, 2024

I'd like to work on it.

@shahinyan11
Copy link

I would like to work on this

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 21, 2024
@MahmudjonToraqulov
Copy link
Contributor

PR is Ready.

Cc: @MitchExpensify @sobitneupane

@sobitneupane
Copy link
Contributor

I will be able to review the PR in the weekend only.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 16, 2024
Copy link
Author

melvin-bot bot commented Feb 16, 2024

This issue has not been updated in over 15 days. @sobitneupane, @MitchExpensify, @MahmudjonToraqulov eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Mar 27, 2024

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'NewChatSelector' page to TypeScript [HOLD for payment 2024-04-15] [$250] [TS migration] Migrate 'NewChatSelector' page to TypeScript Apr 8, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024
Copy link
Author

melvin-bot bot commented Apr 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Apr 8, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@sobitneupane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@MitchExpensify
Copy link
Contributor

Payment summary:

@JmillsExpensify
Copy link

$250 approved for @sobitneupane

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 14, 2024
@MitchExpensify
Copy link
Contributor

Friendly bump on the regression test proposal @sobitneupane

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Apr 15, 2024

Paid @MahmudjonToraqulov, thank you!

Closing as I believe no regression tests needed for this TS migration but please let me know if that's wrong @sobitneupane

@MahmudjonToraqulov
Copy link
Contributor

Paid @MahmudjonToraqulov, thank you!

Closing as I believe no regression tests needed for this TS migration but please let me know if that's wring @sobitneupane

Thank you too.

And I want to say Thank you to @blazejkustra and @sobitneupane. It was my first PR and Contribution for Expensify so I got some problems but you both helped me a lot. I really appreciate it. I'll try to solve every problems myself next time. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests