Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] Wallet - On first try, SSN is verified after second attempt to submit the form #32083

Closed
2 of 6 tasks
kbecciv opened this issue Nov 28, 2023 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Nov 28, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: unable to check production
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31401

Action Performed:

  1. Go to staging.new.expensify.com
  2. Login with an expensifail account.
  3. Go to Settings > Wallet > Enable Wallet.
  4. Follow the flow until your reach the "Additional details" page.
  5. Fill the form with following data: First name: Alberta, Last name: Bobbeth, SSN: 3333, Any other information for the rest of the fields.
  6. Tap on "Save & continue".

Expected Result:

The user should be taken to the nest step without any issues.

Actual Result:

An error message appears the first time the user hits the "Save & continue" button. If the user taps on it again without any change on the fields, then the SSN is verified.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6292499_1701131064344.Tmga3871_1_.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 28, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@luacmartins
Copy link
Contributor

We CPed a revert. Closing.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Nov 28, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 29, 2023
@melvin-bot melvin-bot bot changed the title Wallet - On first try, SSN is verified after second attempt to submit the form [HOLD for payment 2023-12-06] Wallet - On first try, SSN is verified after second attempt to submit the form Nov 29, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@s77rt
Copy link
Contributor

s77rt commented Nov 29, 2023

This does not seem to be a regression from #31401. It just happen that it was found during its QA

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 30, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-06] Wallet - On first try, SSN is verified after second attempt to submit the form [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] Wallet - On first try, SSN is verified after second attempt to submit the form Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@mountiny
Copy link
Contributor

mountiny commented Dec 1, 2023

@luacmartins Apparently this failed on the latest staging #32266 (comment) maybe there is some misunderstanding with expected resutlts, but I am reopning just so we can check if this is fine.

Feel free to close again if all if expected

@mountiny mountiny reopened this Dec 1, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Dec 5, 2023
Copy link

melvin-bot bot commented Dec 7, 2023

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary (SO)[https://stackoverflowteams.com/c/expensify/questions/17778].

@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2023
@luacmartins
Copy link
Contributor

This is expected. Closing!

@melvin-bot melvin-bot bot removed the Overdue label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants