[$500] iOS - Login - Paste menu does not point to the correct field on magic code page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5.7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open New Expensify app
2. Enter any email to try to log in
3. Copy the magic code
4. Try to paste the magic code on any field that is not the first one

Expected Result:

The paste menu should point to the field the user is trying to paste the code

Actual Result:

The paste menu does not point to the correct field, is always pointing to the first field of the magic code

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6295303_1701302822057.Bjxf4284_1_.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[s-alves10]

This looks like a regression of the PR #28711

[aimane-chnaif]

you meant #28711?

[aimane-chnaif]

It's already 2nd version of magic code input refactor.
It's better to fix quickly than revert.
cc: @wojtus7

[kosmydel]

Hey, I'm from SWM and I'm currently responsible for the magic code blur issue.

It looks like it was a conscious decision to leave it like this. It was pointed out here and approved here and here.

So in my opinion, it is not a deploy blocker.

cc @dangrous, @Santhosh-Sellavel

[mountiny]

Yeah I dont think this is a blocker, tested this and you can just fine paste it in if you focus on the first number

Assigning Santosh and Kuba in the meantime if we decide this needs to be fixed or not

[Santhosh-Sellavel]

This is a known issue. cc: @dangrous

[dangrous]

Yeah I think we're okay with this. If we CAN find a solution that would be neat, but I think it's not a bug, just a shift from before.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[NikkiWines]

Unassigning @kosmydel since we determined this wasn't a regression from the previously mentioned PR and we're opening up this issue for proposals

[joekaufmanexpensify]

I kinda think we should do nothing about this and close the issue. We auto-focus to the first field of the magic code after the user submits their email and moves to the magic code page.

I don't think it will be common for someone to actively then choose to click on a different one of the 6 fields and try to paste the code there. If they do, pasting the code beginning with where they focused doesn't seem wrong to me.

In an ideal world, it'd be cool if pasting the code to any one of the 6 fields auto adjusts the code into the correct place. But that doesn't seem like a bug fix IMO, it seems like a new feature. And not one that really feels like a priority. Personally, I think it makes sense to leave as is, and reevaluate if any actual customers run into an issue with this.

[joekaufmanexpensify]

Closing. LMK if anyone disagrees!