[$500] Distance - Request created with ../participants link returns app to request steps when going back

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Tap FAB > Request money > Distance.
3. Modify the link to .../new/participants.
4. Continue with Distance request creation.
5. After creating the request, return to previous page using device navigation (or browser back button for web).

Expected Result:

App will return to the previous report or LHN.

Actual Result:

App returns to the distance request creation steps (confirmation page, workspace selection, request money page) rather than LHN. Request money page appears multiple times when attempting to return to LHN using device back button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6295893_1701346058422.Screen_Recording_20231130_091745_Chrome.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01720a2862d083fa1d

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Request created with ../participants link returns app to request steps when going back

What is the root cause of that problem?

The root cause of the problem is this line of code

App/src/libs/actions/Report.js

Line 2014 in bdbfb2a

Navigation.navigate(route, CONST.NAVIGATION.ACTION_TYPE.PUSH);

that was added in this pr to solve deeplinking issue on logout for Android.
So when we manually navigate to ../participants link openReportFromDeepLink is called and inside it we run this line of code after interaction via InteractionManager.runAfterInteractions.

App/src/libs/actions/Report.js

Line 2014 in bdbfb2a

Navigation.navigate(route, CONST.NAVIGATION.ACTION_TYPE.PUSH);

So this line of code will push unnecessary additional route (RightModalNavigator) to navigation state adding unnecessary RightModalNavigator route making the routes to be length of three (instead of two) with two of them RightModalNavigator routes. So after finishing the money request creation process only one of the RightModalNavigator is replaced with the report route by dismissModal therefore when we navigate back from the report it will navigate back to the other unnecessarily added RightModalNavigator route added to the navigation state instead of the LHN.

What changes do you think we should make in order to solve the problem?

We just need to add a condition here

App/src/libs/actions/Report.js

Line 2014 in bdbfb2a

Navigation.navigate(route, CONST.NAVIGATION.ACTION_TYPE.PUSH);

to check that it is native b/c we only need it to run for native as I explained to fix deeplinking problem.
so change it to

if (!willBlurTextInputOnTapOutside) {
                    Navigation.navigate(route, CONST.NAVIGATION.ACTION_TYPE.PUSH);
                }

POC:

2023-11-30.19-31-57.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

@eVoloshchak, @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@eVoloshchak, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@eVoloshchak, @kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[kevinksullivan]

Hey @eVoloshchak can you review the above please?

[eVoloshchak]

Looks like we recently changed how the link is structured,https://staging.new.expensify.com/create/request/participants opens a not found page, while https://staging.new.expensify.com/request/new/participants is redirecting to manual request tab

@FitseTLT, could you please verify this is still reproducible for you?

[FitseTLT]

@eVoloshchak Can't.

[melvin-bot]

@eVoloshchak @kevinksullivan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@eVoloshchak, @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[kevinksullivan]

Closing unless someone shows this is still reproducible.