[HOLD for payment 2022-04-12] [$2000] Edit Comment - There's no emoji picker when editing a comment

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

Edit comment should have the emoji picker option.

Actual Result:

Edit comment doesn't have the option to add an emoji. User has to manually add them via another method.

Action Performed:

1. Log in to e.cash.
2. Navigate to a conversation
3. Edit an owned message.

Workaround:

User has to manually add the emoji via another method.

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️

Version Number: 1.0.58-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Upwork job link: https://www.upwork.com/jobs/~01f4378b0dd44f2dfa

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[TomatoToaster]

I've got an idea how to do this one and think it'll be fun, so I'll work on it. I'm going to label it weekly since it doesn't seem to be an originally intended feature, and has a workaround.

My plan is to replicate the Emoji logic in src/pages/home/report/ReportActionCompose.js into src/pages/home/report/ReportActionCompose.js, see what's common and then see if it makes sense to make it into an independent component. Or maybe bring more features from the ReportActionCompose into the component so they can be shared between the two.

[TomatoToaster]

Didn't get to working on this yet, still planning to work on it some time this week.

[TomatoToaster]

Ok still had to focus on N7/N5.5 stuff last week and up until now. I still want to work on this because I've got a solution planned for it though so I'll hold onto this for now.

[TomatoToaster]

Still haven't gotten to this. To be fair I think we can categorize this as monthly since it's not the most pressing issue. But anyone feel free to change it back if I should work on it ASAP

[TomatoToaster]

Still haven't gotten to it, but not a priority I'd still say.

[TomatoToaster]

Hadn't worked on this since my last update, but with N6 closing up I should get time for this soon.

[TomatoToaster]

Haven't forgotten about this! Still planning to work on it, just haven't made progress since last update.

[mananjadhav]

@TomatoToaster I just raised this as a feature request. If you’re not planning to pick this soon, I can probably give it a try?

[TomatoToaster]

Feel free @mananjadhav!

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[puneetlath]

Hm, how would we go about addressing this. I think we probably will want to use the inline emoji picker that we plan to create at some point. @stitesExpensify thoughts?

[Julesssss]

That seems more than fair to me. Given there were three big tasks, I think it makes sense to double twice.

[Julesssss]

@laurenreidexpensify would you mind updating the Upwork job, please?

[laurenreidexpensify]

@mananjadhav @parasharrajat ignore what the Upwork job says, when we get to payment I'll make sure you are both compensated the issue total of $2000 each

[stitesExpensify]

@mananjadhav is this issue related to this bug? #8379 (comment)

[mananjadhav]

Commented #8379 (comment)

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.49-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• PR 3: Adding EmojiPicker to the Edit Comment #7580

If no regressions arise, payment will be issued on 2022-04-12. 🎊

[melvin-bot]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[laurenreidexpensify]

@stephanieelliott I am OOO next week when payment is due.

TLDR is that the upwork jobs are incorrect, and both Manan (C) and Rajat (C+) should be compensated $2000 for this issue. You may be best off creating a brand new issue in Upwork for this. Thanks

[mananjadhav]

Given there were three big tasks, I think it makes sense to double twice.

@laurenreidexpensify @Julesssss Is it too late to ask for the revision (sorry I was OOO). I should've mentioned the revised offer earlier, I was wondering if it could be 2500$.

[stephanieelliott]

We're ready to pay this out, @Julesssss what are your thoughts on increasing this to $2500 per @mananjadhav's comment above?

[Julesssss]

Hey @stephanieelliott, yeah that seems reasonable to me. My initial doubling twice was fairly arbitrary.

[stephanieelliott]

We needed to create a new $2500 job in Upwork for this, the old one was incorrect.

Created the job here: https://www.upwork.com/jobs/~016cc1da42d4cf9fec

@mananjadhav and @parasharrajat I invited you both to the job, please accept and I will issue payment ASAP!

[stephanieelliott]

All paid!