-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Navigation - App background is shown as white instead of black (desktop, ios) #32695
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @tylerkaraszewski ( |
Removing deploy blocker |
@tylerkaraszewski I can take this one, it's from the theme switching changes |
@grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@grgia Eep! 4 days overdue now. Issues have feelings too... |
This is related to the forced dark mode change |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-26. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-28. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
|
@grgia Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@grgia Still overdue 6 days?! Let's take care of this! |
@grgia 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Triggered auto assignment to @bfitzexpensify ( |
This comment was marked as off-topic.
This comment was marked as off-topic.
@bfitzexpensify could you help me out with the $500 C+ review payment to @situchan for review of #32672 |
Sure, offer sent @situchan |
All done here. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.9-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
(These are just different ways to focus solely on the background color)
Expected Result:
User expects the apps native background color to be black to match the "Dark" theme of the app and match the PROD black background
Actual Result:
On Staging, the apps background has been changed to white and is now very noticeable
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6304818_1701974177278.Background_color_on_Staging_is_White.mp4
Bug6304818_1701974747560.White_background_is_shown_when_returning_from_Sleep_mode_on_web.mp4
Bug6304818_1701974550483.On_Desktop_app_there_is_a_white_border_.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: