Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Navigation - App background is shown as white instead of black (desktop, ios) #32695

Closed
2 of 6 tasks
lanitochka17 opened this issue Dec 7, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.9-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Access staging.new.expensify.com
  2. Open the keyboard to sign in (Observe the background)

  1. Open the Desktop app
  2. Resize the window (Observe the background)
    (These are just different ways to focus solely on the background color)

Expected Result:

User expects the apps native background color to be black to match the "Dark" theme of the app and match the PROD black background

Actual Result:

On Staging, the apps background has been changed to white and is now very noticeable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6304818_1701974177278.Background_color_on_Staging_is_White.mp4

Bug6304818_1701974177265!Background_color_

Bug6304818_1701974747560.White_background_is_shown_when_returning_from_Sleep_mode_on_web.mp4
Bug6304818_1701974550483.On_Desktop_app_there_is_a_white_border_.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 7, 2023

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@grgia grgia removed the DeployBlockerCash This issue or pull request should block deployment label Dec 7, 2023
@grgia
Copy link
Contributor

grgia commented Dec 7, 2023

Removing deploy blocker

@grgia grgia added the Daily KSv2 label Dec 7, 2023
@grgia grgia assigned grgia and unassigned tylerkaraszewski Dec 7, 2023
@grgia
Copy link
Contributor

grgia commented Dec 7, 2023

@tylerkaraszewski I can take this one, it's from the theme switching changes
cc @chrispader

@grgia grgia removed the Hourly KSv2 label Dec 7, 2023
@grgia grgia changed the title Navigation - App background is shown as white instead of black [Theme Switching] 🐛 Navigation - App background is shown as white instead of black (desktop, ios) Dec 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

@grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Dec 13, 2023

@grgia Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2023
@grgia
Copy link
Contributor

grgia commented Dec 13, 2023

This is related to the forced dark mode change

@chrispader
Copy link
Contributor

chrispader commented Dec 13, 2023

Fixed in this PR: #32672

cc @grgia

@melvin-bot melvin-bot bot added Overdue Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Dec 18, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching] 🐛 Navigation - App background is shown as white instead of black (desktop, ios) [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Navigation - App background is shown as white instead of black (desktop, ios) Dec 19, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Navigation - App background is shown as white instead of black (desktop, ios) [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Navigation - App background is shown as white instead of black (desktop, ios) Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 25, 2023
Copy link

melvin-bot bot commented Dec 28, 2023

@grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jan 1, 2024

@grgia Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Jan 1, 2024

@grgia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@grgia grgia added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 2, 2024
Copy link

melvin-bot bot commented Jan 2, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

This comment was marked as off-topic.

@grgia
Copy link
Contributor

grgia commented Jan 2, 2024

@bfitzexpensify could you help me out with the $500 C+ review payment to @situchan for review of #32672

@bfitzexpensify
Copy link
Contributor

Sure, offer sent @situchan

@bfitzexpensify
Copy link
Contributor

All done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
No open projects
Development

No branches or pull requests

6 participants