Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Contact method - Error message when add contact method is not translated to Spanish #32754

Closed
6 tasks done
lanitochka17 opened this issue Dec 8, 2023 · 11 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.10-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open staging.new.expensify.com
  2. Navigate to Settings> Preferences> Language> Spanish
  3. Go to Settings> Profile> Contact Method
  4. Add receipts@expensify.com
    as contact method

Expected Result:

Error message should be present in Spanish language

Actual Result:

Error message is displayed in English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6306304_1702070204501.az_recorder_20231208_185325.mp4

Bug6306304_1702070204481!image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e336f47edd43fd48
  • Upwork Job ID: 1733237184652222464
  • Last Price Increase: 2023-12-08
Issue OwnerCurrent Issue Owner: @garrettmknight
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 8, 2023
@melvin-bot melvin-bot bot changed the title Contact method - Error message when add contact method is not translated to Spanish [$500] Contact method - Error message when add contact method is not translated to Spanish Dec 8, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e336f47edd43fd48

Copy link

melvin-bot bot commented Dec 8, 2023

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 8, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 8, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@ZhenjaHorbach
Copy link
Contributor

Looks like BE issue

@nikos-amofa
Copy link
Contributor

nikos-amofa commented Dec 8, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message while adding receipts@expensify.com as contact method doesn't show in Spanish, when the language preference is set to Spanish

What is the root cause of that problem?

The error message is from the backend when failed to add the contact method.
The UI just shows the error message.

Screen.Recording.2023-12-08.at.5.20.25.PM.mov

What changes do you think we should make in order to solve the problem?

This requires collaboration with the backend team.

  1. The error message in En/Sp will be added to src/languages/en.ts and es.ts
  2. If the code: 666(OR type: Expensify\\Error\\User\\CannotAddSecondaryLogin) corresponds to this error case, check the code and show the error message from the message added step 1. This will be decided with the collaboration of the backend team.
  3. Else, collaborate with the backend team to add a new field, something like reason: ADMINISTRATOR_RESTRICTED. And for this error, show the error message from step 1.

@AmjedNazzal
Copy link
Contributor

This is a BE issue as it was decided not to expand on local translation and there will be consideration in the future to support Spanish by the BE side and local translation will be deprecated eventually from what I understood looking at discussions of similar issues in the past.

@Santhosh-Sellavel
Copy link
Collaborator

@garrettmknight I think we can close this, Can you check internally let me whats the action plan, thanks!

@garrettmknight
Copy link
Contributor

@AmjedNazzal can you point me to the thread where this was decided? I couldn't find it on a quick search.

@AmjedNazzal
Copy link
Contributor

AmjedNazzal commented Dec 12, 2023

@garrettmknight #26621 (comment) not the exact same issue but the general idea I was trying to talk about is that the BE doesn't return Spanish and it seem to be something that was decided to be put aside along with similar Spanish related issues until BE localisation becomes supported.

@garrettmknight
Copy link
Contributor

Thanks @AmjedNazzal - closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants