Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Desktop - Magic code link opens the app, but it glitches and returns to the login screen #32783

Closed
1 of 6 tasks
lanitochka17 opened this issue Dec 11, 2023 · 21 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.10-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Prerequisites: User must be logged into web app as User A.

  1. Launch the Desktop app
  2. Enter an email for an existing or new account
  3. Go to the email inbox and locate the magic code
  4. Copy the Magic link and modify it to staging
  5. On the web, open a new tab and navigate to the staging magic link
  6. Confirm that the user is prompted to open the desktop app
  7. Click on the "Open app" option

Expected Result:

When redirected to the desktop app the user must be logged into the new or existing account and no visual problems should be observed

Actual Result:

When the desktop is launched by the magic code link, it glitches, briefly shows a skeleton and then returns to the first login screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6308322_1702253651026.Glitches_in_the_first_launch_-_Staging.mp4

logs.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0190046c73ec67f0a3
  • Upwork Job ID: 1734155185383477248
  • Last Price Increase: 2024-01-04
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 11, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 11, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Julesssss
Copy link
Contributor

Julesssss commented Dec 11, 2023

I'm not convinced that this does work on Prod. First I see a 'Oops this page cannot be found' message, then when I refresh I am taken back to the authentication page.

Screenshot 2023-12-11 at 10 14 28 Screenshot 2023-12-11 at 10 14 34

@Julesssss
Copy link
Contributor

Lets see if we can locate the regression, but this shouldn't block the release because:

  • You cannot currently sign in on production using the link
  • It only occurs on Desktop

@Julesssss Julesssss assigned Julesssss and unassigned marcaaron Dec 11, 2023
@Julesssss Julesssss added Daily KSv2 Hourly KSv2 Improvement Item broken or needs improvement. External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Dec 11, 2023
@melvin-bot melvin-bot bot changed the title Desktop - Magic code link opens the app, but it glitches and returns to the login screen [$500] Desktop - Magic code link opens the app, but it glitches and returns to the login screen Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0190046c73ec67f0a3

Copy link

melvin-bot bot commented Dec 11, 2023

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 11, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@Julesssss Julesssss added Daily KSv2 and removed Hourly KSv2 labels Dec 11, 2023
@Julesssss
Copy link
Contributor

Closing in favour of this similar, but more descriptive issue

Copy link

melvin-bot bot commented Dec 12, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@kavimuru
Copy link

kavimuru commented Dec 27, 2023

Issue is reproduced today as well. So reopening the issue.

Staging.repro.mov

@kavimuru kavimuru reopened this Dec 27, 2023
Copy link

melvin-bot bot commented Dec 28, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
Copy link

melvin-bot bot commented Jan 1, 2024

@eVoloshchak @Julesssss @muttmuure this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

1 similar comment
Copy link

melvin-bot bot commented Jan 1, 2024

@eVoloshchak @Julesssss @muttmuure this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@muttmuure
Copy link
Contributor

Looking at higher priority items first

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
Copy link

melvin-bot bot commented Jan 4, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 4, 2024
Copy link

melvin-bot bot commented Jan 5, 2024

@eVoloshchak, @Julesssss, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

@muttmuure
Copy link
Contributor

I'm not able to reproduce this because when I put the link into Chrome it doesn't give me the option to open desktop at all

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2024
Copy link

melvin-bot bot commented Jan 8, 2024

@eVoloshchak @Julesssss @muttmuure this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 8, 2024
Copy link

melvin-bot bot commented Jan 8, 2024

Current assignee @eVoloshchak is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Jan 10, 2024
@muttmuure
Copy link
Contributor

Can't reproduce this. What I am seeing is:

  1. Generate magic code from desktop app
  2. Copy paste staging.new.expensify.com link into browser
  3. The page opens to the magic sign in code. (There is no option to open Desktop).

You can opt to sign in there with the magic link, and then using the link to authorize a desktop sign in is expired. However, that seems like a separate problem

@melvin-bot melvin-bot bot removed the Overdue label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

6 participants