[HOLD for payment 2024-03-05] [Contributor] Add Visit Expensify Classic Button to NewDot

[danielrvidal]

Part of #wave9-collect-signups project

Main issue: Originated from this internal issue: https://github.com/Expensify/Expensify/issues/344901
Doc section: no design doc - this was pre-designed already.
Project: #wave9-collect-signups

Feature Description

Problem: As we start migrating users from OldDot to NewDot and point new signUps to NewDot, some users will require OldDot functionality to complete tasks, add secondary logins, use functionality not available on NewDot, access old expense/reports, and so on. If a user currently is in NewDot, the most straightforward way to access OldDot is to open a new tab and type in expensify.com to get to OldDot, which causes confusion. If they have the tryNewDot redirect, typing in expensify.com would not work and you’d have to send them a specific link or instructions how to do so.

Solution: Add a button in NewDot to allow user to easily navigate to OldDot.

• Note: some users have the tryNewDot NVP applied to their accounts which means if they type in www.expensify.com, they are redirected to OldDot. This will not remove the NVP but will allow the user to be taken to the inbox.

Where will we add the button?
You’d find the button by going to Avatar > Settings. Then above Sign Out we’ll add the button Go to Expensify Classic (Image in thread of where it will go). Mock up here:

What will the button do?

• Web (desktop/mobile) - opens up a new tab for https://www.expensify.com/inbox
• NewDot App - leaves the app and opens up a new tab for https://www.expensify.com/inbox in your default browser
• [HOLD] HybridApp - stays in HybridApp and goes to settings in OldDot. The hybrid app is not ready yet so we do not need to account for this use case yet, but just accounting that it will be here later.

I think this should have everything you need to complete this. Please feel free to ask me any questions.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0183075eef93ad0483
• Upwork Job ID: 1734346213197549568
• Last Price Increase: 2023-12-11

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0183075eef93ad0483

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add Visit Expensify Classic Button to NewDot

What is the root cause of that problem?

New Feature

What changes do you think we should make in order to solve the problem?

We will be adding another menuItem here, before Sign Out button.

App/src/pages/settings/InitialSettingsPage.js

Lines 259 to 265 in 165caf5

	{
	translationKey: 'initialSettingsPage.signOut',
	icon: Expensicons.Exit,
	action: () => {
	signOut(false);
	},
	},

{
    translationKey: 'initialSettingsPage.goToExpensifyClassic',
    icon: Expensicons.Expensify,
    iconRight: Expensicons.NewWindow,
    action: () => {    
        Linking.openURL(CONST.OLDDOT_URL);
    },
},

And add this CONST variable:

OLDDOT_URL: 'https://www.expensify.com/'

[AndrewGable]

@neonbhai - This issue is labeled internal, which means it's not currently open to proposals. We will let you know if this changes in the future. Thanks!

[neonbhai]

@AndrewGable ah right. Thanks!

[barttom]

Hey, I'm Bartek from Callstack - expert contributor group - I would like to work on this issue

[barttom]

I haven't found a needed icon for this item, so I've converted https://github.com/Expensify/App/blob/main/assets/images/expensify-logo-round-transparent.png as best as I could 🙈
If exists that icon in SVG format or if You have it prepared please let me know

[melvin-bot]

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

[kadiealexander]

Hey @dubielzyk-expensify, could you please share a transparent svg of our round E logo? Like this one https://github.com/Expensify/App/blob/main/assets/images/expensify-logo-round-transparent.png but in SVG form. Thanks!

[barttom]

What about label translation for Spanish, is `'Ir a Expensify Classic' ok?

[dubielzyk-expensify]

@kadiealexander : Can we use this?

[danielrvidal]

What about label translation for Spanish, is `'Ir a Expensify Classic' ok?

Yes, that works @barttom

[kadiealexander]

@dubielzyk-expensify that should work great thanks!

[kadiealexander]

@barttom let us know if you need anything else for this one!

[barttom]

@kadiealexander Thanks a lot, that's all I need.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/32875/svg color and olddot url #33863

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @barttom does not require payment (Contractor)
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[kadiealexander]

@thesahindia don't forget the checklist please!

[kadiealexander]

@thesahindia bump!

[kadiealexander]

@thesahindia is OOO sick, no update.

[thesahindia]

@kadiealexander, we are fixing a regression here.

[kadiealexander]

Not overdue, please switch back to daily when the regression fix is deployed.

[kadiealexander]

Not overdue, regression was merged 2 days ago.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @barttom is from an agency-contributor and not due payment
• Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@kadiealexander)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1734346213197549568/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @barttom is from an agency-contributor and not due payment
• Reviewer: @thesahindia owed $500 via NewDot

BugZero Checklist (@kadiealexander)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1734346213197549568/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[kadiealexander]

I have updated the payment amount to reflect the regression. @thesahindia please request payment via NewDot.