Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right clicking an image or link should show the Native OS menu #3317

Closed
isagoico opened this issue Jun 2, 2021 · 8 comments
Closed

Right clicking an image or link should show the Native OS menu #3317

isagoico opened this issue Jun 2, 2021 · 8 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Weekly KSv2

Comments

@isagoico
Copy link

isagoico commented Jun 2, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Right clicking an image or link should show the Native OS menu so the user has several options to choose on what to do.

Actual Result:

Link
When right clicking the link there's only the option to copy to clipboard the whole message. If there's a long message with a link included in the middle the only way of copying the link is to manually selecting it and click on copy to clipboard. E.g in the next screenshot.
image

Image
When right clicking the image, there's only the option to copy to clipboard. If you copy and paste the image this issue will occur #3313.

Action Performed:

Link steps

  1. Log in to e.cash.
  2. Navigate to a conversation
  3. Send a message with a link in the middle of normal text
  4. Right click the link and copy to clipboard
  5. Paste the content in a text input.

Image steps

  1. Log in to e.cash
  2. Navigate to a conversation
  3. Send an image
  4. Right click the image

Workaround:

Only way to copy a link in a long message is to manually selecting it and clicking on copy to clipboard. For images, you have to open the preview and right clicking (it will show the native OS menu)

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.60-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1622579145427200

We sequester the right click button to show the actions menu, but that makes it impossible to copy a link that's in a comment or being able to copy an image pasted.
Like if the message is: Hey Isabella, the issue you want is #3313
I want to be able to right click that link and open it in a new tab for example or copy its address. I don't want to copy the whole message.

@MelvinBot
Copy link

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Jun 3, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@stitesExpensify stitesExpensify added Weekly KSv2 and removed Daily KSv2 labels Jun 3, 2021
@MelvinBot MelvinBot added the Daily KSv2 label Jun 3, 2021
@stitesExpensify stitesExpensify added Improvement Item broken or needs improvement. and removed Daily KSv2 labels Jun 3, 2021
@roryabraham
Copy link
Contributor

I think this is prettymuch a duplicate of #3313. Let's close this an just beef up the scope of that other one a bit.

@iwiznia
Copy link
Contributor

iwiznia commented Jun 8, 2021

I don't think it is.. that one is so that we don't copy formatting when copying the whole message, this is to allow to copy a link or image from within a message... right?

@iwiznia iwiznia reopened this Jun 8, 2021
@roryabraham
Copy link
Contributor

I updated the OP of the other one with the following functionality:

- User should be able to copy images and link URLs when using the copy to clipboard feature.
- Right-clicking or long-pressing on a link should open the `ReportActionContextMenu`, but the `Copy to Clipboard` menu item should instead say `Copy URL to Clipboard`. Pressing that menu item, the link url should be copied to the clipboard.
- Right-clicking or long-pressing on an image should open the `ReportActionContextMenu`, but the `Copy to Clipboard` menu should instead say `Copy Image to Clipboard`. Pressing that menu item, the image should be copied to the clipboard.

Does that prettymuch cover the improvements we're looking for between these two issues?

@jboniface
Copy link

Am I supposed to action this?

@jboniface
Copy link

@roryabraham just checking back on this, does it need to be open/external?

@roryabraham
Copy link
Contributor

No, I still think this is a dupe of #3313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants