[$500] Assign task -Inconsistent name for actions(Test Rail vs Expensify)

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: @

Action Performed:

1. Log in to a Staging.new.expensify.com
2. Navigate to Assign Task
3. Create a task

Expected Result:

In the LHN, the preview shows "Created the task" [task name]

Actual Result:

In the LHN the preview shows "task for" [task name]

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6314819_1702655475718.bugtaskname.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d4634a71bd760d18
• Upwork Job ID: 1735703690736652288
• Last Price Increase: 2023-12-15

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d4634a71bd760d18

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task -Inconsistent name for actions

What is the root cause of that problem?

We use a different copy in the app here.

What changes do you think we should make in order to solve the problem?

We should fix the copy here:

App/src/languages/en.ts

Line 1708 in 6fc070b

created: ({title}: TaskCreatedActionParams) => `task for ${title}`,

created: ({title}: TaskCreatedActionParams) => `Created the task ${title}`,

[paultsimura]

I remember this was agreed to be intentional when discussing #29035, e.g. here: https://expensify.slack.com/archives/C01GTK53T8Q/p1701334749349619

[neonbhai]

@paultsimura right does seem that way.

Maybe we could ask the Design team to clarify the expected message here.

cc: @puneetlath

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the LHN the preview shows "task for" [task name]

What is the root cause of that problem?

Currently, we are using "task for" [task name] when creating new task

App/src/languages/en.ts

Line 1708 in e2eca1b

created: ({title}: TaskCreatedActionParams) => `task for ${title}`,

App/src/languages/es.ts

Line 1734 in e2eca1b

created: ({title}: TaskCreatedActionParams) => `tarea para ${title}`,

App/src/libs/actions/Task.js

Line 74 in e2eca1b

const optimisticAddCommentReport = ReportUtils.buildOptimisticTaskCommentReportAction(taskReportID, title, assigneeAccountID, `task for ${title}`, parentReportID);

What changes do you think we should make in order to solve the problem?

We need to update all the above places from task for to Created the task

In here

App/src/libs/actions/Task.js

Line 74 in e2eca1b

const optimisticAddCommentReport = ReportUtils.buildOptimisticTaskCommentReportAction(taskReportID, title, assigneeAccountID, `task for ${title}`, parentReportID);

We can consider to use transaction by updating like this

Localize.translateLocal('task.messages.created', {title})

What alternative solutions did you explore? (Optional)

NA

[thienlnam]

We should update the test rail, the way we have it in product is correct

[puneetlath]

Issue for updating testrail. https://github.com/Expensify/Expensify/issues/351443