-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update style for violations #33527
Comments
Triggered auto assignment to @dubielzyk-expensify ( |
I applied the design label for good measure, but I think you've already specified how things need to look in the linked PR |
I'd be happy to take this as C+ |
Hello Thanks in advance. |
📣 @JaimisMiyani! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@cead22, @dubielzyk-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@JaimisMiyani we're working with Infinite Red at the moment to implement these changes for violations |
Infinite Red is out til 2024, so I made this weekly for now |
Any updates on this one? |
Not yet, Trevor and Lizzi from Infinite Red are handling all the front end issue for violations, and they're working on one at a time, and both have one issue assigned at the moment |
@cead22 -- I can pick this up now that ReportUtils is pretty much done. |
Work in progress |
I was pulled for the C+ review. Review is in progress. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
This issue has not been updated in over 15 days. @cead22, @dubielzyk-expensify eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Triggered auto assignment to @MitchExpensify ( |
@MitchExpensify can you please handle payment to @cubuspl42 for the review? Thanks! |
Invited you for payment here, @cubuspl42 https://www.upwork.com/jobs/~015d4a656c0b6fb3d7 |
Accepted 👍 |
Paid and contract ended! |
@lindboe @trevor-coleman can you comment here for assignment please?
cc @Expensify/design
Issue Owner
Current Issue Owner: @cead22The text was updated successfully, but these errors were encountered: