Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style for violations #33527

Closed
cead22 opened this issue Dec 22, 2023 · 23 comments
Closed

Update style for violations #33527

cead22 opened this issue Dec 22, 2023 · 23 comments
Assignees
Labels
Design Engineering Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@cead22
Copy link
Contributor

cead22 commented Dec 22, 2023

  • This is a followup to this PR Update MoneyRequestView.js to show Violations #32594
  • We need to update the styles of the violations messages such that they're aligned in the same wat as error messages in form input fields are aligned, and the hoverable styles match those of the input row when the input row has the cursor over it

@lindboe @trevor-coleman can you comment here for assignment please?
cc @Expensify/design

Issue OwnerCurrent Issue Owner: @cead22
@cead22 cead22 added Engineering Daily KSv2 Improvement Item broken or needs improvement. Design labels Dec 22, 2023
@cead22 cead22 self-assigned this Dec 22, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

@cead22
Copy link
Contributor Author

cead22 commented Dec 22, 2023

I applied the design label for good measure, but I think you've already specified how things need to look in the linked PR

@aimane-chnaif
Copy link
Contributor

I'd be happy to take this as C+

@JaimisMiyani
Copy link

Hello
I would love to contribute. let me know if there is any issue.

Thanks in advance.

Copy link

melvin-bot bot commented Dec 23, 2023

📣 @JaimisMiyani! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@JaimisMiyani
Copy link

Contributor details
Your Expensify account email: jaimismiyani12@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010843db372089015a

Copy link

melvin-bot bot commented Dec 23, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

@cead22, @dubielzyk-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@cead22
Copy link
Contributor Author

cead22 commented Dec 26, 2023

@JaimisMiyani we're working with Infinite Red at the moment to implement these changes for violations

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 26, 2023
@cead22 cead22 added Weekly KSv2 and removed Daily KSv2 labels Dec 29, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 29, 2023
@cead22
Copy link
Contributor Author

cead22 commented Dec 29, 2023

Infinite Red is out til 2024, so I made this weekly for now

@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2024
@dubielzyk-expensify
Copy link
Contributor

Any updates on this one?

@melvin-bot melvin-bot bot removed the Overdue label Jan 10, 2024
@cead22
Copy link
Contributor Author

cead22 commented Jan 10, 2024

Not yet, Trevor and Lizzi from Infinite Red are handling all the front end issue for violations, and they're working on one at a time, and both have one issue assigned at the moment

@trevor-coleman
Copy link
Contributor

@cead22 -- I can pick this up now that ReportUtils is pretty much done.

@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
@cead22
Copy link
Contributor Author

cead22 commented Jan 19, 2024

Work in progress

@melvin-bot melvin-bot bot removed the Overdue label Jan 19, 2024
@cubuspl42
Copy link
Contributor

I was pulled for the C+ review. Review is in progress.

Copy link

melvin-bot bot commented Feb 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 15, 2024
Copy link

melvin-bot bot commented Feb 15, 2024

This issue has not been updated in over 15 days. @cead22, @dubielzyk-expensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@cead22 cead22 closed this as completed Feb 16, 2024
@cead22 cead22 reopened this Feb 16, 2024
@cead22 cead22 added the NewFeature Something to build that is a new item. label Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 16, 2024
@cead22
Copy link
Contributor Author

cead22 commented Feb 16, 2024

@MitchExpensify can you please handle payment to @cubuspl42 for the review? Thanks!

@MitchExpensify
Copy link
Contributor

Invited you for payment here, @cubuspl42 https://www.upwork.com/jobs/~015d4a656c0b6fb3d7

@cubuspl42
Copy link
Contributor

Accepted 👍

@MitchExpensify
Copy link
Contributor

Paid and contract ended!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Engineering Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants