Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-04] [$250] Android - Workspace - Card icon is shown as a green square icon #33594

Closed
1 of 6 tasks
kbecciv opened this issue Dec 26, 2023 · 53 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Dec 26, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to Settings > Workspaces > any workspace.

Expected Result:

All icons are displayed properly.

Actual Result:

Card icon is shown as a green square icon.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b583b60c7afce86e
  • Upwork Job ID: 1739665839943921664
  • Last Price Increase: 2023-12-26
  • Automatic offers:
    • situchan | Contributor | 28070426
    • aswin-s | Contributor | 28070450
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Dec 26, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 26, 2023

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor

Potentially related to the expo image update, but its odd this is only happening on native android

@mountiny
Copy link
Contributor

QA confirmed only happening on native android

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Dec 26, 2023
@melvin-bot melvin-bot bot changed the title Android - Workspace - Card icon is shown as a green square icon [$500] Android - Workspace - Card icon is shown as a green square icon Dec 26, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b583b60c7afce86e

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 26, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@mountiny
Copy link
Contributor

Actually found that this will most likely be related to the expo image update as there were some other icons which had similar issue https://expensify.slack.com/archives/C01GTK53T8Q/p1703186271886829

@mountiny
Copy link
Contributor

cc @akinwale @WojtekBoman

@mountiny mountiny changed the title [$500] Android - Workspace - Card icon is shown as a green square icon [$250] Android - Workspace - Card icon is shown as a green square icon Dec 26, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

Upwork job price has been updated to $250

@tienifr

This comment was marked as outdated.

@mountiny
Copy link
Contributor

Still looking for proposals

@Tony-MK
Copy link
Contributor

Tony-MK commented Dec 26, 2023

On the dev environment, it seems like it works properly.

Screenshot

@mountiny
Copy link
Contributor

I do not have android to confirm this in staging/ prod

@mountiny
Copy link
Contributor

Thanks! @Tony-MK Do you for sure have the latest main with expo-image installed?

@shubham1206agra
Copy link
Contributor

Screenshot 2023-12-26 at 9 42 01 PM

Not able to repro this on emulator

@Pujan92
Copy link
Contributor

Pujan92 commented Dec 26, 2023

Same for me too.

Screenshot_1703607135

@situchan
Copy link
Contributor

@mountiny can we get android apk for staging build? Contributors don't have access to it

@mountiny
Copy link
Contributor

Lets check on some adhoc build waiting for some to finish

@Tony-MK
Copy link
Contributor

Tony-MK commented Dec 26, 2023

@mountiny It was version v1.4.17-1 Develop but it seems other contributors have verified it.

@ishpaul777
Copy link
Contributor

Tested on latest main on physical device, not reproducable.
PHOTO-2023-12-26-21-56-59

@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Dec 27, 2023
@melvin-bot melvin-bot bot changed the title [$250] Android - Workspace - Card icon is shown as a green square icon [HOLD for payment 2024-01-03] [$250] Android - Workspace - Card icon is shown as a green square icon Dec 27, 2023
Copy link

melvin-bot bot commented Dec 27, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 27, 2023
Copy link

melvin-bot bot commented Dec 27, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 27, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
  • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@situchan] Determine if we should create a regression test for this bug.
  • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 28, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-03] [$250] Android - Workspace - Card icon is shown as a green square icon [HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$250] Android - Workspace - Card icon is shown as a green square icon Dec 28, 2023
Copy link

melvin-bot bot commented Dec 28, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 28, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
  • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@situchan] Determine if we should create a regression test for this bug.
  • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jan 2, 2024
Copy link

melvin-bot bot commented Jan 5, 2024

@JmillsExpensify, @aswin-s, @mountiny, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny mountiny changed the title [HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$250] Android - Workspace - Card icon is shown as a green square icon [HOLD for payment 2024-01-04] [$250] Android - Workspace - Card icon is shown as a green square icon Jan 5, 2024
Copy link

melvin-bot bot commented Jan 9, 2024

@JmillsExpensify, @aswin-s, @mountiny, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@mountiny
Copy link
Contributor

@situchan can you please complete the checklist here?

Summary is $250 to @aswin-s and $250 to @situchan

Copy link

melvin-bot bot commented Jan 11, 2024

@JmillsExpensify, @aswin-s, @mountiny, @situchan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@situchan
Copy link
Contributor

Not able to find offending PR but from deploy checklist, I think expo-image PR is the culprit.
This was caught by QA team during regression test so no need new regression test.
To prevent such bugs further, it would be good to add eslint rule to avoid duplicated resource file names after excluding -, but not a big deal.

@melvin-bot melvin-bot bot removed the Overdue label Jan 11, 2024
@mountiny
Copy link
Contributor

@JmillsExpensify ready for payment

@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

@JmillsExpensify, @aswin-s, @mountiny, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Jan 17, 2024

@JmillsExpensify, @aswin-s, @mountiny, @situchan Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 19, 2024

@JmillsExpensify, @aswin-s, @mountiny, @situchan Still overdue 6 days?! Let's take care of this!

@JmillsExpensify
Copy link

Payment summary:

@melvin-bot melvin-bot bot removed the Overdue label Jan 24, 2024
@JmillsExpensify
Copy link

All contracts paid out, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests