-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-01-04] [$250] Android - Workspace - Card icon is shown as a green square icon #33594
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @mountiny ( |
Potentially related to the expo image update, but its odd this is only happening on native android |
QA confirmed only happening on native android |
Job added to Upwork: https://www.upwork.com/jobs/~01b583b60c7afce86e |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
Actually found that this will most likely be related to the expo image update as there were some other icons which had similar issue https://expensify.slack.com/archives/C01GTK53T8Q/p1703186271886829 |
Upwork job price has been updated to $250 |
This comment was marked as outdated.
This comment was marked as outdated.
Still looking for proposals |
I do not have android to confirm this in staging/ prod |
Thanks! @Tony-MK Do you for sure have the latest main with expo-image installed? |
@mountiny can we get android apk for staging build? Contributors don't have access to it |
Lets check on some adhoc build waiting for some to finish |
@mountiny It was version |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-03. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-04. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@JmillsExpensify, @aswin-s, @mountiny, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@JmillsExpensify, @aswin-s, @mountiny, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
@JmillsExpensify, @aswin-s, @mountiny, @situchan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
Not able to find offending PR but from deploy checklist, I think expo-image PR is the culprit. |
@JmillsExpensify ready for payment |
@JmillsExpensify, @aswin-s, @mountiny, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@JmillsExpensify, @aswin-s, @mountiny, @situchan Eep! 4 days overdue now. Issues have feelings too... |
@JmillsExpensify, @aswin-s, @mountiny, @situchan Still overdue 6 days?! Let's take care of this! |
All contracts paid out, closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
All icons are displayed properly.
Actual Result:
Card icon is shown as a green square icon.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @JmillsExpensifyThe text was updated successfully, but these errors were encountered: